LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: iommu@lists.linux-foundation.org
Cc: linux-kernel@vger.kernel.org, "Christoph Hellwig" <hch@lst.de>,
	"Christian König" <christian.koenig@amd.com>,
	"Michel Dänzer" <michel@daenzer.net>,
	"Takashi Iwai" <tiwai@suse.de>
Subject: [PATCH] swiotlb: Silent unwanted warning "buffer is full"
Date: Thu, 3 May 2018 23:54:46 +0200	[thread overview]
Message-ID: <20180503235446.6a3d3118@endymion> (raw)

If DMA_ATTR_NO_WARN is passed to swiotlb_alloc_buffer(), it should be
passed further down to swiotlb_tbl_map_single(). Otherwise we escape
half of the warnings but still log the other half.

This is one of the multiple causes of spurious warnings reported at:
https://bugs.freedesktop.org/show_bug.cgi?id=104082

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Fixes: 0176adb00406 ("swiotlb: refactor coherent buffer allocation")
Cc: Christoph Hellwig <hch@lst.de>
Cc: Christian König <christian.koenig@amd.com>
Cc: Michel Dänzer <michel@daenzer.net>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: stable@vger.kernel.org # v4.16
---
 lib/swiotlb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-4.16.orig/lib/swiotlb.c	2018-05-02 15:06:49.677769532 +0200
+++ linux-4.16/lib/swiotlb.c	2018-05-03 15:04:27.136921225 +0200
@@ -727,7 +727,7 @@ swiotlb_alloc_buffer(struct device *dev,
 
 	phys_addr = swiotlb_tbl_map_single(dev,
 			swiotlb_phys_to_dma(dev, io_tlb_start),
-			0, size, DMA_FROM_DEVICE, 0);
+			0, size, DMA_FROM_DEVICE, attrs);
 	if (phys_addr == SWIOTLB_MAP_ERROR)
 		goto out_warn;
 


-- 
Jean Delvare
SUSE L3 Support

             reply	other threads:[~2018-05-03 21:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03 21:54 Jean Delvare [this message]
2018-05-12 10:02 ` Christoph Hellwig
2018-05-13  8:35   ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180503235446.6a3d3118@endymion \
    --to=jdelvare@suse.de \
    --cc=christian.koenig@amd.com \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michel@daenzer.net \
    --cc=tiwai@suse.de \
    --subject='Re: [PATCH] swiotlb: Silent unwanted warning "buffer is full"' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).