LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/2] pinctrl: mvebu: update use "nand" function for "rb" pin
@ 2018-05-04  3:06 Chris Packham
  2018-05-04  3:06 ` [PATCH 2/2] ARM: dts: armada-xp-98dx: Add NAND pinctrl information Chris Packham
  2018-05-14 11:49 ` [PATCH 1/2] pinctrl: mvebu: update use "nand" function for "rb" pin Gregory CLEMENT
  0 siblings, 2 replies; 4+ messages in thread
From: Chris Packham @ 2018-05-04  3:06 UTC (permalink / raw)
  To: andrew, gregory.clement, linux-arm-kernel, devicetree
  Cc: Chris Packham, Jason Cooper, Sebastian Hesselbarth,
	Linus Walleij, linux-gpio, linux-kernel

The Armada 98dx3236 SoCs don't have a different MPP sel value for nand
specific pins so "dev" was technically correct. But all the other Armada
SoCs use "nand" in their dts and the pin is specific to the nand
interface so use "nand" for the function name.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
 drivers/pinctrl/mvebu/pinctrl-armada-xp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-xp.c b/drivers/pinctrl/mvebu/pinctrl-armada-xp.c
index b854f1ee5de5..28b199796fae 100644
--- a/drivers/pinctrl/mvebu/pinctrl-armada-xp.c
+++ b/drivers/pinctrl/mvebu/pinctrl-armada-xp.c
@@ -431,7 +431,7 @@ static struct mvebu_mpp_mode mv98dx3236_mpp_modes[] = {
 	MPP_MODE(19,
 		 MPP_VAR_FUNCTION(0x0, "gpio", NULL,         V_98DX3236_PLUS),
 		 MPP_VAR_FUNCTION(0x3, "uart1", "rxd",       V_98DX3236_PLUS),
-		 MPP_VAR_FUNCTION(0x4, "dev", "rb",          V_98DX3236_PLUS)),
+		 MPP_VAR_FUNCTION(0x4, "nand", "rb",         V_98DX3236_PLUS)),
 	MPP_MODE(20,
 		 MPP_VAR_FUNCTION(0x0, "gpo", NULL,          V_98DX3236_PLUS),
 		 MPP_VAR_FUNCTION(0x4, "dev", "we0",         V_98DX3236_PLUS)),
-- 
2.17.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] ARM: dts: armada-xp-98dx: Add NAND pinctrl information
  2018-05-04  3:06 [PATCH 1/2] pinctrl: mvebu: update use "nand" function for "rb" pin Chris Packham
@ 2018-05-04  3:06 ` Chris Packham
  2018-05-14 11:49   ` Gregory CLEMENT
  2018-05-14 11:49 ` [PATCH 1/2] pinctrl: mvebu: update use "nand" function for "rb" pin Gregory CLEMENT
  1 sibling, 1 reply; 4+ messages in thread
From: Chris Packham @ 2018-05-04  3:06 UTC (permalink / raw)
  To: andrew, gregory.clement, linux-arm-kernel, devicetree
  Cc: Chris Packham, Jason Cooper, Sebastian Hesselbarth, Rob Herring,
	Mark Rutland, linux-kernel

Add pin control information for the NAND interface on the Armada
98DX3236 and variants.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
 arch/arm/boot/dts/armada-xp-98dx3236.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm/boot/dts/armada-xp-98dx3236.dtsi b/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
index 9a589abd0379..099dc2520082 100644
--- a/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
+++ b/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
@@ -312,6 +312,19 @@
 &pinctrl {
 	compatible = "marvell,98dx3236-pinctrl";
 
+	nand_pins: nand-pins {
+		marvell,pins = "mpp20", "mpp21", "mpp22",
+			       "mpp23", "mpp24", "mpp25",
+			       "mpp26", "mpp27", "mpp28",
+			       "mpp29", "mpp30";
+		marvell,function = "dev";
+	};
+
+	nand_rb: nand-rb {
+		marvell,pins = "mpp19";
+		marvell,function = "nand";
+	};
+
 	spi0_pins: spi0-pins {
 		marvell,pins = "mpp0", "mpp1",
 			       "mpp2", "mpp3";
-- 
2.17.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] pinctrl: mvebu: update use "nand" function for "rb" pin
  2018-05-04  3:06 [PATCH 1/2] pinctrl: mvebu: update use "nand" function for "rb" pin Chris Packham
  2018-05-04  3:06 ` [PATCH 2/2] ARM: dts: armada-xp-98dx: Add NAND pinctrl information Chris Packham
@ 2018-05-14 11:49 ` Gregory CLEMENT
  1 sibling, 0 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2018-05-14 11:49 UTC (permalink / raw)
  To: Chris Packham
  Cc: andrew, linux-arm-kernel, devicetree, Jason Cooper,
	Linus Walleij, linux-kernel, linux-gpio, Sebastian Hesselbarth

Hi Chris,
 
 On ven., mai 04 2018, Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:

> The Armada 98dx3236 SoCs don't have a different MPP sel value for nand
> specific pins so "dev" was technically correct. But all the other Armada
> SoCs use "nand" in their dts and the pin is specific to the nand
> interface so use "nand" for the function name.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>

Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com>

Thanks,

Gregory
> ---
>  drivers/pinctrl/mvebu/pinctrl-armada-xp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-xp.c b/drivers/pinctrl/mvebu/pinctrl-armada-xp.c
> index b854f1ee5de5..28b199796fae 100644
> --- a/drivers/pinctrl/mvebu/pinctrl-armada-xp.c
> +++ b/drivers/pinctrl/mvebu/pinctrl-armada-xp.c
> @@ -431,7 +431,7 @@ static struct mvebu_mpp_mode mv98dx3236_mpp_modes[] = {
>  	MPP_MODE(19,
>  		 MPP_VAR_FUNCTION(0x0, "gpio", NULL,         V_98DX3236_PLUS),
>  		 MPP_VAR_FUNCTION(0x3, "uart1", "rxd",       V_98DX3236_PLUS),
> -		 MPP_VAR_FUNCTION(0x4, "dev", "rb",          V_98DX3236_PLUS)),
> +		 MPP_VAR_FUNCTION(0x4, "nand", "rb",         V_98DX3236_PLUS)),
>  	MPP_MODE(20,
>  		 MPP_VAR_FUNCTION(0x0, "gpo", NULL,          V_98DX3236_PLUS),
>  		 MPP_VAR_FUNCTION(0x4, "dev", "we0",         V_98DX3236_PLUS)),
> -- 
> 2.17.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] ARM: dts: armada-xp-98dx: Add NAND pinctrl information
  2018-05-04  3:06 ` [PATCH 2/2] ARM: dts: armada-xp-98dx: Add NAND pinctrl information Chris Packham
@ 2018-05-14 11:49   ` Gregory CLEMENT
  0 siblings, 0 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2018-05-14 11:49 UTC (permalink / raw)
  To: Chris Packham
  Cc: andrew, linux-arm-kernel, devicetree, Mark Rutland, Jason Cooper,
	linux-kernel, Rob Herring, Sebastian Hesselbarth

Hi Chris,
 
 On ven., mai 04 2018, Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:

> Add pin control information for the NAND interface on the Armada
> 98DX3236 and variants.
>


Applied on mvebu/dt

Thanks,

Gregory


> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
>  arch/arm/boot/dts/armada-xp-98dx3236.dtsi | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-xp-98dx3236.dtsi b/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
> index 9a589abd0379..099dc2520082 100644
> --- a/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
> +++ b/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
> @@ -312,6 +312,19 @@
>  &pinctrl {
>  	compatible = "marvell,98dx3236-pinctrl";
>  
> +	nand_pins: nand-pins {
> +		marvell,pins = "mpp20", "mpp21", "mpp22",
> +			       "mpp23", "mpp24", "mpp25",
> +			       "mpp26", "mpp27", "mpp28",
> +			       "mpp29", "mpp30";
> +		marvell,function = "dev";
> +	};
> +
> +	nand_rb: nand-rb {
> +		marvell,pins = "mpp19";
> +		marvell,function = "nand";
> +	};
> +
>  	spi0_pins: spi0-pins {
>  		marvell,pins = "mpp0", "mpp1",
>  			       "mpp2", "mpp3";
> -- 
> 2.17.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-05-14 11:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-04  3:06 [PATCH 1/2] pinctrl: mvebu: update use "nand" function for "rb" pin Chris Packham
2018-05-04  3:06 ` [PATCH 2/2] ARM: dts: armada-xp-98dx: Add NAND pinctrl information Chris Packham
2018-05-14 11:49   ` Gregory CLEMENT
2018-05-14 11:49 ` [PATCH 1/2] pinctrl: mvebu: update use "nand" function for "rb" pin Gregory CLEMENT

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).