LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Liviu Dudau <liviu.dudau@arm.com>
To: Satendra Singh Thakur <satendra.t@samsung.com>
Cc: dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] drm/kms/mode: added a new helper for calculating videomode from crtc's display mode
Date: Fri, 4 May 2018 10:38:54 +0100	[thread overview]
Message-ID: <20180504093854.GJ1027@e110455-lin.cambridge.arm.com> (raw)
In-Reply-To: <1525424523-3367-1-git-send-email-satendra.t@samsung.com>

On Fri, May 04, 2018 at 02:32:03PM +0530, Satendra Singh Thakur wrote:
> On Thu, May 03, 2018 at 11:36:39 +0100, Liviu Dudau wrote:
> > On Thu, May 03, 2018 at 11:28:37AM +0530, Satendra Singh Thakur wrote:
> > > 1.
> > > -Added a new helper drm_display_mode_crtc_to_videomode
> > > -This helper calculates mode parameters like
> > >   horizontal front_porch, back_porch, sync length
> > >   vertical front_porch, back_porch, sync length
> > >   using crtc_* fields of struct drm_display_mode
> > > -It uses following fields of crtc mode
> > >  horizontal sync start/end, active and total length
> > >  vertical sync start/end, active and total length
> > > 2.
> > > -Most of the driver use user-supplied mode for calculating videomode
> > > -However, few drivers use HW (crtc) mode for calculating videomode
> > > -This helper will be useful for such drivers
> > > 3.
> > > -Currently following drivers will be using this new helper
> > > -arm hdlcd
> > > -atmel hlcdc
> > > -exynos 5433 decon
> > > -exynos7 decon
> > > -exynos fimd
> > > 4.
> > > -This patch removes related duplicate code from above mentioned drivers
> > > 
> > > Signed-off-by: Satendra Singh Thakur <satendra.t@samsung.com>
> > > Cc: Madhur Verma <madhur.verma@samsung.com>
> > > Cc: Hemanshu Srivastava <hemanshu.s@samsung.com>
> > > ---
> > >  drivers/gpu/drm/arm/hdlcd_crtc.c               |  8 +-------
> > >  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c |  7 +------
> > >  drivers/gpu/drm/drm_modes.c                    | 20 ++++++++++++++++++++
> > >  drivers/gpu/drm/exynos/exynos5433_drm_decon.c  | 22 ++++++++++------------
> > >  drivers/gpu/drm/exynos/exynos7_drm_decon.c     | 23 ++++++++++-------------
> > >  drivers/gpu/drm/exynos/exynos_drm_fimd.c       | 22 +++++++++-------------
> > >  include/drm/drm_modes.h                        |  2 ++
> > >  7 files changed, 53 insertions(+), 51 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/arm/hdlcd_crtc.c b/drivers/gpu/drm/arm/hdlcd_crtc.c
> > > index cf5cbd6..d20e471 100644
> > > --- a/drivers/gpu/drm/arm/hdlcd_crtc.c
> > > +++ b/drivers/gpu/drm/arm/hdlcd_crtc.c
> > > @@ -130,13 +130,7 @@ static void hdlcd_crtc_mode_set_nofb(struct drm_crtc *crtc)
> > >  	struct videomode vm;
> > >  	unsigned int polarities, err;
> > >  
> > > -	vm.vfront_porch = m->crtc_vsync_start - m->crtc_vdisplay;
> > > -	vm.vback_porch = m->crtc_vtotal - m->crtc_vsync_end;
> > > -	vm.vsync_len = m->crtc_vsync_end - m->crtc_vsync_start;
> > > -	vm.hfront_porch = m->crtc_hsync_start - m->crtc_hdisplay;
> > > -	vm.hback_porch = m->crtc_htotal - m->crtc_hsync_end;
> > > -	vm.hsync_len = m->crtc_hsync_end - m->crtc_hsync_start;
> > > -
> > > +	drm_display_mode_crtc_to_videomode(m, &vm);
> > >  	polarities = HDLCD_POLARITY_DATAEN | HDLCD_POLARITY_DATA;
> > >  
> > >  	if (m->flags & DRM_MODE_FLAG_PHSYNC)
> >
> > For the HDLCD part:
> > 
> > Acked-by: Liviu Dudau <liviu.dudau@arm.com>
> > 
> > If you're not sending the final version through drm-misc then let me
> > know and I can pick up the HDLCD part separately.
> >
> > Best regards,
> > Liviu
> >
> >
> 
> Hi Mr Liviu,
> Thanks for accepting the patch.
> I don't know how to send patch through drm-misc.
> You may please go ahead and pick HDLCD part separately.

Lets wait for the maintainers of other drivers to give their ACKs and
then we'll sort out the submission. Usually it is just a matter of
asking for the patch to be pulled from the relevant people. For drm-misc
there are quite a few people and with enough patches accepted others can
join too. I'll just put here some names, in no particular order, that
you can ask for the patch to be pulled.

Gustavo Padovan <gustavo@padovan.org>
Daniel Stone <daniel@fooishbar.org>
Eric Anholt <eric@anholt.net>
Jani Nikula <jani.nikula@intel.com>
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Sean Paul <seanpaul@chromium.org>
Daniel Vetter <daniel.vetter@intel.com>

Best regards,
Liviu

> 
> Thanks
> -Satendra

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯

  reply	other threads:[~2018-05-04  9:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180503055902epcas5p2eea7b9f58dc630e60fb28c8fc2ffad7b@epcas5p2.samsung.com>
2018-05-03  5:58 ` [PATCH] " Satendra Singh Thakur
2018-05-03  8:02   ` Jani Nikula
2018-05-03 10:36   ` Liviu Dudau
     [not found]     ` <CGME20180504074013epcas5p4564cb7043e1875154469052d097848db@epcas5p4.samsung.com>
2018-05-04  7:40       ` [PATCH v1] " Satendra Singh Thakur
     [not found]         ` <CGME20180504090214epcas5p4e9c362da6cc7b65effcc042fc4f82d2a@epcas5p4.samsung.com>
2018-05-04  9:02           ` Satendra Singh Thakur
2018-05-04  9:38             ` Liviu Dudau [this message]
2018-05-04  9:41         ` Jani Nikula
     [not found]           ` <CGME20180507033149epcas5p4b33b68a21f0883da6aa97419d5114296@epcas5p4.samsung.com>
2018-05-07  3:31             ` [PATCH v2] " Satendra Singh Thakur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180504093854.GJ1027@e110455-lin.cambridge.arm.com \
    --to=liviu.dudau@arm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=satendra.t@samsung.com \
    --subject='Re: [PATCH v1] drm/kms/mode: added a new helper for calculating videomode from crtc'\''s display mode' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).