LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Wolfram Sang <wsa@the-dreams.de>,
	linux-iio@vger.kernel.org, linux-fpga@vger.kernel.org,
	linux-remoteproc@vger.kernel.org, alsa-devel@alsa-project.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Eric Anholt <eric@anholt.net>,
	netdev@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-i2c@vger.kernel.org, linux1394-devel@lists.sourceforge.net,
	Christoph Hellwig <hch@lst.de>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Stefan Wahren <stefan.wahren@i2se.com>,
	Boris Brezillon <boris.brezillon@free-electrons.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Richard Weinberger <richard@nod.at>,
	Joerg Roedel <joro@8bytes.org>,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	linux-serial@vger.kernel.org, Matias Bjorling <mb@lightnvm.io>,
	David Woodhouse <dwmw2@infradead.org>,
	linux-media@vger.kernel.org, Ohad Ben-Cohen <ohad@wizery.com>,
	devel@driverdev.osuosl.org, Alan Tull <atull@kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	Mark Brown <broonie@kernel.org>, Moritz Fischer <mdf@kernel.org>,
	linux-fbdev@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Kalle Valo <kvalo@codeaurora.org>,
	Felipe Balbi <balbi@kernel.org>,
	linux-ide@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-mmc@vger.kernel.org,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-spi@vger.kernel.org, iommu@lists.linux-foundation.org,
	Stefan Richter <stefanr@s5r6.in-berlin.de>,
	linux-crypto@vger.kernel.org,
	Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
	Tejun Heo <tj@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Robin Murphy <robin.murphy@arm.com>,
	"David S . Miller" <davem@davemloft.net>,
	Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v3 12/20] media: Remove depends on HAS_DMA in case of platform dependency
Date: Sat, 5 May 2018 09:47:43 -0300	[thread overview]
Message-ID: <20180505094743.4d201ba0@vento.lan> (raw)
In-Reply-To: <1523987360-18760-13-git-send-email-geert@linux-m68k.org>

Hi Geert,

Em Tue, 17 Apr 2018 19:49:12 +0200
Geert Uytterhoeven <geert@linux-m68k.org> escreveu:

> Remove dependencies on HAS_DMA where a Kconfig symbol depends on another
> symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST".

Applying a patch like that is hard, as there are lots of churn at
the code. That's against latest media upstream:

checking file drivers/media/pci/intel/ipu3/Kconfig
Hunk #1 FAILED at 4.
1 out of 1 hunk FAILED
checking file drivers/media/pci/solo6x10/Kconfig
checking file drivers/media/pci/sta2x11/Kconfig
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED
checking file drivers/media/pci/tw5864/Kconfig
checking file drivers/media/pci/tw686x/Kconfig
checking file drivers/media/platform/Kconfig
Hunk #2 FAILED at 63.
Hunk #3 succeeded at 81 (offset 1 line).
Hunk #4 succeeded at 91 (offset 1 line).
Hunk #5 succeeded at 101 (offset 1 line).
Hunk #6 succeeded at 111 (offset 1 line).
Hunk #7 succeeded at 124 (offset 1 line).
Hunk #8 succeeded at 142 (offset 1 line).
Hunk #9 succeeded at 169 (offset 1 line).
Hunk #10 succeeded at 186 (offset 1 line).
Hunk #11 succeeded at 197 (offset 1 line).
Hunk #12 succeeded at 213 (offset 1 line).
Hunk #13 succeeded at 227 (offset 1 line).
Hunk #14 succeeded at 254 (offset 1 line).
Hunk #15 succeeded at 265 (offset 1 line).
Hunk #16 succeeded at 275 (offset 1 line).
Hunk #17 succeeded at 284 (offset 1 line).
Hunk #18 succeeded at 295 (offset 1 line).
Hunk #19 succeeded at 303 (offset 1 line).
Hunk #20 succeeded at 312 (offset 1 line).
Hunk #21 succeeded at 338 (offset 1 line).
Hunk #22 succeeded at 383 (offset 1 line).
Hunk #23 succeeded at 397 (offset 1 line).
Hunk #24 succeeded at 422 (offset 1 line).
Hunk #25 succeeded at 435 (offset 1 line).
Hunk #26 succeeded at 452 (offset 1 line).
Hunk #27 succeeded at 470 (offset 1 line).
Hunk #28 succeeded at 612 (offset 1 line).
1 out of 28 hunks FAILED

> In most cases this other symbol is an architecture or platform specific
> symbol, or PCI.
> 
> Generic symbols and drivers without platform dependencies keep their
> dependencies on HAS_DMA, to prevent compiling subsystems or drivers that
> cannot work anyway.

Actually, depends on HAS_DMA was introduced on media because builds
were failing otherwise. We started adding it before the addition 
of COMPILE_TEST.

Can we just remove all HAS_DMA Kconfig dependencies as a hole from the
entire media subsystem, with something like:

	$ for i in $(find drivers/media -name Kconfig) $(find drivers/staging/media -name Kconfig); do sed '/depends on HAS_DMA/d;s/ && HAS_DMA//g' -i $i; done

Or would it cause build issues?

Regards,
Mauro




Thanks,
Mauro
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2018-05-05 12:47 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-17 17:49 [PATCH v3 00/20] Allow compile-testing NO_DMA (drivers) Geert Uytterhoeven
2018-04-17 17:49 ` [PATCH v3 01/20] ASoC: Remove depends on HAS_DMA in case of platform dependency Geert Uytterhoeven
2018-04-17 17:49 ` [PATCH v3 02/20] ata: " Geert Uytterhoeven
2018-04-17 17:49 ` [PATCH v3 03/20] crypto: " Geert Uytterhoeven
2018-04-28  8:24   ` Herbert Xu
2018-04-17 17:49 ` [PATCH v3 04/20] fbdev: " Geert Uytterhoeven
2018-04-17 17:49 ` [PATCH v3 05/20] firewire: " Geert Uytterhoeven
2018-04-17 17:49 ` [PATCH v3 06/20] fpga: " Geert Uytterhoeven
2018-04-17 17:49 ` [PATCH v3 07/20] i2c: " Geert Uytterhoeven
2018-04-18  7:01   ` Wolfram Sang
2018-04-17 17:49 ` [PATCH v3 08/20] iio: adc: " Geert Uytterhoeven
2018-04-17 17:49 ` [PATCH v3 09/20] iommu: " Geert Uytterhoeven
2018-05-03 13:02   ` Joerg Roedel
2018-04-17 17:49 ` [PATCH v3 10/20] lightnvm: " Geert Uytterhoeven
2018-04-17 17:49 ` [PATCH v3 11/20] mailbox: " Geert Uytterhoeven
2018-04-17 17:49 ` [PATCH v3 12/20] media: " Geert Uytterhoeven
2018-05-05 12:47   ` Mauro Carvalho Chehab [this message]
2018-05-07  7:21     ` Geert Uytterhoeven
2018-04-17 17:49 ` [PATCH v3 13/20] mmc: " Geert Uytterhoeven
2018-04-19 13:17   ` Ulf Hansson
2018-04-17 17:49 ` [PATCH v3 14/20] mtd: " Geert Uytterhoeven
2018-04-22 17:12   ` Boris Brezillon
2018-04-17 17:49 ` [PATCH v3 15/20] net: " Geert Uytterhoeven
2018-04-19 16:41   ` Kalle Valo
2018-04-17 17:49 ` [PATCH v3 16/20] remoteproc: " Geert Uytterhoeven
2018-04-17 17:49 ` [PATCH v3 17/20] serial: " Geert Uytterhoeven
2018-04-17 17:49 ` [PATCH v3 18/20] spi: " Geert Uytterhoeven
2018-04-17 17:49 ` [PATCH v3 19/20] staging: vc04_services: " Geert Uytterhoeven
2018-04-17 17:49 ` [PATCH v3 20/20] usb: " Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180505094743.4d201ba0@vento.lan \
    --to=mchehab+samsung@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=atull@kernel.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=balbi@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=boris.brezillon@free-electrons.com \
    --cc=broonie@kernel.org \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@wedev4u.fr \
    --cc=davem@davemloft.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=dwmw2@infradead.org \
    --cc=eric@anholt.net \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@lst.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=jic23@kernel.org \
    --cc=joro@8bytes.org \
    --cc=kvalo@codeaurora.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=m.szyprowski@samsung.com \
    --cc=marek.vasut@gmail.com \
    --cc=mb@lightnvm.io \
    --cc=mchehab@kernel.org \
    --cc=mdf@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ohad@wizery.com \
    --cc=richard@nod.at \
    --cc=robin.murphy@arm.com \
    --cc=stefan.wahren@i2se.com \
    --cc=stefanr@s5r6.in-berlin.de \
    --cc=tj@kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=wsa@the-dreams.de \
    --subject='Re: [PATCH v3 12/20] media: Remove depends on HAS_DMA in case of platform dependency' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).