LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Eugen Hristev <eugen.hristev@microchip.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	ludovic.desroches@microchip.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
	linux-input@vger.kernel.org, nicolas.ferre@microchip.com,
	dmitry.torokhov@gmail.com, robh@kernel.org
Subject: Re: [PATCH v4 5/9] iio: adc: at91-sama5d2_adc: add support for position and pressure channels
Date: Mon, 7 May 2018 12:28:10 +0200	[thread overview]
Message-ID: <20180507102810.GO10960@piout.net> (raw)
In-Reply-To: <eaeced9e-390f-0eea-0466-66c789bacdd6@microchip.com>

On 07/05/2018 09:18:39+0300, Eugen Hristev wrote:
> On 06.05.2018 20:59, Alexandre Belloni wrote:
> > Hi,
> > 
> > On 06/05/2018 18:29:53+0100, Jonathan Cameron wrote:
> > > On Mon, 30 Apr 2018 13:32:11 +0300
> > > Eugen Hristev <eugen.hristev@microchip.com> wrote:
> > > 
> > > > This implements the support for position and pressure for the included
> > > > touchscreen support in the SAMA5D2 SOC ADC block.
> > > > Two position channels are added and one for pressure.
> > > > They can be read in raw format, or through a buffer.
> > > > A normal use case is for a consumer driver to register a callback buffer
> > > > for these channels.
> > > > When the touchscreen channels are in the active scan mask,
> > > > the driver will start the touchscreen sampling and push the data to the
> > > > buffer.
> > > > 
> > > > Some parts of this patch are based on initial original work by
> > > > Mohamed Jamsheeth Hajanajubudeen and Bandaru Venkateswara Swamy
> > > > 
> > > > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> > > Looks good to me now.
> > > 
> > > I'm assuming that once Dmitry and others are happy, I'll take the
> > > series through the IIO tree. Will reply to the cover letter if the
> > > rest of the patches look good to me to let everyone know that without
> > > having to catch this comment down in here!
> > > 
> > 
> > I'm planning to take both DT patches through the at91 tree once you take
> > the DT bindings patches.
> 
> Please take into consideration that those DT patches do not build
> stand-alone, they depend on
> [PATCH v4 7/9] dt-bindings: iio: adc: at91-sama5d2_adc: add channel specific
> consumer info
> 
> (the DT patches add an include statement of a file which is created in this
> patch).
> 

So the proper way is to actually have the values in the dt instead of
the define and then patch it on the next version of the kernel.

Or we take the dts patches on the next version.

-- 
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-05-07 10:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30 10:32 [PATCH v4 0/9] Add support for SAMA5D2 touchscreen Eugen Hristev
2018-04-30 10:32 ` [PATCH v4 1/9] MAINTAINERS: add generic resistive touchscreen adc Eugen Hristev
2018-04-30 10:32 ` [PATCH v4 2/9] iio: Add channel for Position Relative Eugen Hristev
2018-04-30 10:32 ` [PATCH v4 3/9] dt-bindings: input: touchscreen: add pressure threshold touchscreen property Eugen Hristev
2018-05-07 22:38   ` Dmitry Torokhov
2018-04-30 10:32 ` [PATCH v4 4/9] dt-bindings: input: touchscreen: resistive-adc-touch: create bindings Eugen Hristev
2018-04-30 10:32 ` [PATCH v4 5/9] iio: adc: at91-sama5d2_adc: add support for position and pressure channels Eugen Hristev
2018-05-06 17:29   ` Jonathan Cameron
2018-05-06 17:59     ` Alexandre Belloni
2018-05-07  6:18       ` Eugen Hristev
2018-05-07 10:28         ` Alexandre Belloni [this message]
2018-05-07 10:40           ` Eugen Hristev
2018-04-30 10:32 ` [PATCH v4 6/9] input: touchscreen: resistive-adc-touch: add generic resistive ADC touchscreen Eugen Hristev
2018-05-06 17:33   ` Jonathan Cameron
2018-04-30 10:32 ` [PATCH v4 7/9] dt-bindings: iio: adc: at91-sama5d2_adc: add channel specific consumer info Eugen Hristev
2018-04-30 10:32 ` [PATCH v4 8/9] ARM: dts: at91: sama5d2: add channel cells for ADC device Eugen Hristev
2018-04-30 10:32 ` [PATCH v4 9/9] ARM: dts: at91: sama5d2: Add resistive touch device Eugen Hristev
2018-05-06 19:04 ` [PATCH v4 0/9] Add support for SAMA5D2 touchscreen Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180507102810.GO10960@piout.net \
    --to=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=eugen.hristev@microchip.com \
    --cc=jic23@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=robh@kernel.org \
    --subject='Re: [PATCH v4 5/9] iio: adc: at91-sama5d2_adc: add support for position and pressure channels' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).