LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] Documentation: block: cmdline-partition.txt fixes and additions
@ 2018-05-06 18:50 Randy Dunlap
  2018-05-07  2:43 ` Caizhiyong
  2018-05-08 15:19 ` Jonathan Corbet
  0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2018-05-06 18:50 UTC (permalink / raw)
  To: linux-block, axboe
  Cc: LKML, Cai Zhiyong, Andrew Morton, linux-doc, Jonathan Corbet

From: Randy Dunlap <rdunlap@infradead.org>

Make the description of the kernel command line option "blkdevparts"
a bit more flowing and readable.

Fix a few typos.
Add the optional <size> and <offset> suffixes.
Note that size can be "-" to indicate all of the remaining space.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Cai Zhiyong <caizhiyong@huawei.com>
---
Should the "ro" and "lk" flags options be described?

 Documentation/block/cmdline-partition.txt |   21 +++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

--- linux-next-20180504.orig/Documentation/block/cmdline-partition.txt
+++ linux-next-20180504/Documentation/block/cmdline-partition.txt
@@ -1,7 +1,9 @@
 Embedded device command line partition parsing
 =====================================================================
 
-Support for reading the block device partition table from the command line.
+The "blkdevparts" command line option adds support for reading the
+block device partition table from the kernel command line.
+
 It is typically used for fixed block (eMMC) embedded devices.
 It has no MBR, so saves storage space. Bootloader can be easily accessed
 by absolute address of data on the block device.
@@ -14,22 +16,27 @@ blkdevparts=<blkdev-def>[;<blkdev-def>]
     <partdef> := <size>[@<offset>](part-name)
 
 <blkdev-id>
-    block device disk name, embedded device used fixed block device,
-    it's disk name also fixed. such as: mmcblk0, mmcblk1, mmcblk0boot0.
+    block device disk name. Embedded device uses fixed block device.
+    Its disk name is also fixed, such as: mmcblk0, mmcblk1, mmcblk0boot0.
 
 <size>
     partition size, in bytes, such as: 512, 1m, 1G.
+    size may contain an optional suffix of (upper or lower case):
+      K, M, G, T, P, E.
+    "-" is used to denote all remaining space.
 
 <offset>
     partition start address, in bytes.
+    offset may contain an optional suffix of (upper or lower case):
+      K, M, G, T, P, E.
 
 (part-name)
-    partition name, kernel send uevent with "PARTNAME". application can create
-    a link to block device partition with the name "PARTNAME".
-    user space application can access partition by partition name.
+    partition name. Kernel sends uevent with "PARTNAME". Application can
+    create a link to block device partition with the name "PARTNAME".
+    User space application can access partition by partition name.
 
 Example:
-    eMMC disk name is "mmcblk0" and "mmcblk0boot0"
+    eMMC disk names are "mmcblk0" and "mmcblk0boot0".
 
   bootargs:
     'blkdevparts=mmcblk0:1G(data0),1G(data1),-;mmcblk0boot0:1m(boot),-(kernel)'

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] Documentation: block: cmdline-partition.txt fixes and additions
  2018-05-06 18:50 [PATCH] Documentation: block: cmdline-partition.txt fixes and additions Randy Dunlap
@ 2018-05-07  2:43 ` Caizhiyong
  2018-05-08 15:19 ` Jonathan Corbet
  1 sibling, 0 replies; 3+ messages in thread
From: Caizhiyong @ 2018-05-07  2:43 UTC (permalink / raw)
  To: Randy Dunlap, linux-block, axboe
  Cc: LKML, Andrew Morton, linux-doc, Jonathan Corbet, Jiangheng

> -----Original Message-----
> From: Randy Dunlap [mailto:rdunlap@infradead.org]
> Sent: Monday, May 07, 2018 2:50 AM
> To: linux-block@vger.kernel.org; axboe <axboe@kernel.dk>
> Cc: LKML <linux-kernel@vger.kernel.org>; Caizhiyong
> <caizhiyong@hisilicon.com>; Andrew Morton <akpm@linux-foundation.org>;
> linux-doc@vger.kernel.org; Jonathan Corbet <corbet@lwn.net>
> Subject: [PATCH] Documentation: block: cmdline-partition.txt fixes and
> additions
> 
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Make the description of the kernel command line option "blkdevparts"
> a bit more flowing and readable.
> 
> Fix a few typos.
> Add the optional <size> and <offset> suffixes.
> Note that size can be "-" to indicate all of the remaining space.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Cai Zhiyong <caizhiyong@huawei.com>
> ---
> Should the "ro" and "lk" flags options be described?

thank you for fix typos.
The "ro" and "lk" feature are not implemented in block devices. could you implement them?

>  Documentation/block/cmdline-partition.txt |   21 +++++++++++++-------
>  1 file changed, 14 insertions(+), 7 deletions(-)
> 
> --- linux-next-20180504.orig/Documentation/block/cmdline-partition.txt
> +++ linux-next-20180504/Documentation/block/cmdline-partition.txt
> @@ -1,7 +1,9 @@
>  Embedded device command line partition parsing
> 
> ==========================================================
> ===========
> 
> -Support for reading the block device partition table from the command line.
> +The "blkdevparts" command line option adds support for reading the
> +block device partition table from the kernel command line.
> +
>  It is typically used for fixed block (eMMC) embedded devices.
>  It has no MBR, so saves storage space. Bootloader can be easily accessed
>  by absolute address of data on the block device.
> @@ -14,22 +16,27 @@ blkdevparts=<blkdev-def>[;<blkdev-def>]
>      <partdef> := <size>[@<offset>](part-name)
> 
>  <blkdev-id>
> -    block device disk name, embedded device used fixed block device,
> -    it's disk name also fixed. such as: mmcblk0, mmcblk1, mmcblk0boot0.
> +    block device disk name. Embedded device uses fixed block device.
> +    Its disk name is also fixed, such as: mmcblk0, mmcblk1, mmcblk0boot0.
> 
>  <size>
>      partition size, in bytes, such as: 512, 1m, 1G.
> +    size may contain an optional suffix of (upper or lower case):
> +      K, M, G, T, P, E.
> +    "-" is used to denote all remaining space.
> 
>  <offset>
>      partition start address, in bytes.
> +    offset may contain an optional suffix of (upper or lower case):
> +      K, M, G, T, P, E.
> 
>  (part-name)
> -    partition name, kernel send uevent with "PARTNAME". application can
> create
> -    a link to block device partition with the name "PARTNAME".
> -    user space application can access partition by partition name.
> +    partition name. Kernel sends uevent with "PARTNAME". Application can
> +    create a link to block device partition with the name "PARTNAME".
> +    User space application can access partition by partition name.
> 
>  Example:
> -    eMMC disk name is "mmcblk0" and "mmcblk0boot0"
> +    eMMC disk names are "mmcblk0" and "mmcblk0boot0".
> 
>    bootargs:
>      'blkdevparts=mmcblk0:1G(data0),1G(data1),-;mmcblk0boot0:1m(boot),-
> (kernel)'

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Documentation: block: cmdline-partition.txt fixes and additions
  2018-05-06 18:50 [PATCH] Documentation: block: cmdline-partition.txt fixes and additions Randy Dunlap
  2018-05-07  2:43 ` Caizhiyong
@ 2018-05-08 15:19 ` Jonathan Corbet
  1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2018-05-08 15:19 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: linux-block, axboe, LKML, Cai Zhiyong, Andrew Morton, linux-doc

On Sun, 6 May 2018 11:50:29 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:

> Make the description of the kernel command line option "blkdevparts"
> a bit more flowing and readable.
> 
> Fix a few typos.
> Add the optional <size> and <offset> suffixes.
> Note that size can be "-" to indicate all of the remaining space.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Applied, thanks.

jon

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-08 15:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-06 18:50 [PATCH] Documentation: block: cmdline-partition.txt fixes and additions Randy Dunlap
2018-05-07  2:43 ` Caizhiyong
2018-05-08 15:19 ` Jonathan Corbet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).