LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jslaby@suse.com>, Johan Hovold <johan@kernel.org>, Jacek Anaszewski <jacek.anaszewski@gmail.com>, Pavel Machek <pavel@ucw.cz> Cc: linux-serial@vger.kernel.org, linux-leds@vger.kernel.org, linux-can@vger.kernel.org, kernel@pengutronix.de, One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>, Florian Fainelli <f.fainelli@gmail.com>, Mathieu Poirier <mathieu.poirier@linaro.org>, linux-kernel@vger.kernel.org, Robin Murphy <robin.murphy@arm.com>, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 0/3] led_trigger_register_format and tty triggers Date: Tue, 8 May 2018 12:05:40 +0200 [thread overview] Message-ID: <20180508100543.12559-1-u.kleine-koenig@pengutronix.de> (raw) Hello, while working on a patch that adds led triggers to drivers/tty (patch 3) I thought that being able to pass a format string (and the respective parameters) to led_trigger_register_simple instead of a constant string would be nice. This is implemented in the first patch. The second patch converts the can leds to this new function which demonstrates nicely the added benefit for users. Both patches are new in v3. The third patch finally implements the triggers for the tty framework. Compared to v2 I reduced the need for #ifdefs, make use of led_trigger_register_format() and excluded serdev devices from triggering as suggested by Johan Hovold. Also code cleanup in the error case is done now and hopefully the kbuild test robot is happy now. Best regards Uwe Uwe Kleine-König (3): leds: triggers: provide led_trigger_register_format() can: simplify LED trigger handling tty: implement led triggers arch/arm/boot/dts/imx25-logitech-baby.dts | 192 ++++++++++++++++++++++ drivers/leds/led-triggers.c | 84 +++++++--- drivers/net/can/led.c | 30 +--- drivers/tty/Kconfig | 7 + drivers/tty/tty_buffer.c | 2 + drivers/tty/tty_io.c | 3 + drivers/tty/tty_port.c | 32 +++- include/linux/can/dev.h | 3 - include/linux/leds.h | 30 ++-- include/linux/tty.h | 22 +++ 10 files changed, 341 insertions(+), 64 deletions(-) create mode 100644 arch/arm/boot/dts/imx25-logitech-baby.dts -- 2.17.0
next reply other threads:[~2018-05-08 10:05 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-08 10:05 Uwe Kleine-König [this message] 2018-05-08 10:05 ` [PATCH v3 1/3] leds: triggers: provide led_trigger_register_format() Uwe Kleine-König 2018-05-08 19:33 ` Jacek Anaszewski 2018-05-08 20:17 ` Uwe Kleine-König 2018-05-09 19:57 ` Jacek Anaszewski 2018-05-10 11:21 ` Pavel Machek 2018-05-10 11:22 ` Pavel Machek 2018-05-12 18:59 ` Uwe Kleine-König 2018-05-13 14:34 ` Andy Shevchenko 2018-05-08 10:05 ` [PATCH v3 2/3] can: simplify LED trigger handling Uwe Kleine-König 2018-05-08 11:04 ` Marc Kleine-Budde 2018-05-08 10:05 ` [PATCH v3 3/3] tty: implement led triggers Uwe Kleine-König 2018-05-08 10:08 ` Johan Hovold 2018-05-08 10:51 ` Uwe Kleine-König 2018-05-13 14:23 ` Andy Shevchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180508100543.12559-1-u.kleine-koenig@pengutronix.de \ --to=u.kleine-koenig@pengutronix.de \ --cc=f.fainelli@gmail.com \ --cc=gnomes@lxorguk.ukuu.org.uk \ --cc=gregkh@linuxfoundation.org \ --cc=jacek.anaszewski@gmail.com \ --cc=johan@kernel.org \ --cc=jslaby@suse.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-can@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=mathieu.poirier@linaro.org \ --cc=pavel@ucw.cz \ --cc=robin.murphy@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).