LKML Archive on
help / color / mirror / Atom feed
From: Dan Carpenter <>
To: Wenwen Wang <>
Cc: "open list:STAGING SUBSYSTEM" <>,
	Andy Shevchenko <>,
	Greg Kroah-Hartman <>,
	Kangjie Lu <>,
	open list <>,
	Hans Verkuil <>,
	Sakari Ailus <>,
	Mauro Carvalho Chehab <>,
	Alan Cox <>
Subject: Re: [PATCH] media: staging: atomisp: fix a potential missing-check bug
Date: Tue, 8 May 2018 15:16:35 +0300	[thread overview]
Message-ID: <20180508121635.mdw4jikv66iyprie@mwanda> (raw)
In-Reply-To: <>

On Wed, May 02, 2018 at 05:38:49PM -0500, Wenwen Wang wrote:
> At the end of atomisp_subdev_set_selection(), the function
> atomisp_subdev_get_rect() is invoked to get the pointer to v4l2_rect. Since
> this function may return a NULL pointer, it is firstly invoked to check
> the returned pointer. If the returned pointer is not NULL, then the
> function is invoked again to obtain the pointer and the memory content
> at the location of the returned pointer is copied to the memory location of
> r. In most cases, the pointers returned by the two invocations are same.
> However, given that the pointer returned by the function
> atomisp_subdev_get_rect() is not a constant, it is possible that the two
> invocations return two different pointers. For example, another thread may
> race to modify the related pointers during the two invocations.

You're assuming a very serious race condition exists.

> In that
> case, even if the first returned pointer is not null, the second returned
> pointer might be null, which will cause issues such as null pointer
> dereference.

And then complaining that if a really serious bug exists then this very
minor bug would exist too...  If there were really a race condition like
that then we'd want to fix it instead.  In other words, this is not a
real life bug fix.

But it would be fine as a readability or static checker fix so that's

dan carpenter

  reply	other threads:[~2018-05-08 12:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02 22:38 Wenwen Wang
2018-05-08 12:16 ` Dan Carpenter [this message]
2018-05-08 13:04   ` Wenwen Wang
2018-05-08 13:26     ` Sakari Ailus
  -- strict thread matches above, loose matches on Subject: below --
2018-05-04  7:29 Wenwen Wang
2018-05-04 13:53 ` Andy Shevchenko
2018-04-28 23:02 Wenwen Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180508121635.mdw4jikv66iyprie@mwanda \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] media: staging: atomisp: fix a potential missing-check bug' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).