LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] mptlan: fix mpt_lan_sdu_send()'s return type
@ 2018-04-24 13:15 Luc Van Oostenryck
  2018-05-08  5:21 ` Martin K. Petersen
  0 siblings, 1 reply; 4+ messages in thread
From: Luc Van Oostenryck @ 2018-04-24 13:15 UTC (permalink / raw)
  To: linux-kernel
  Cc: Luc Van Oostenryck, Sathya Prakash, Chaitra P B,
	Suganath Prabu Subramani, MPT-FusionLinux.pdl, linux-scsi

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, but the implementation in this
driver returns an 'int'.

Fix this by returning 'netdev_tx_t' in this driver too.

Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
 drivers/message/fusion/mptlan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/message/fusion/mptlan.c b/drivers/message/fusion/mptlan.c
index 55dd71bbd..4cbed4d06 100644
--- a/drivers/message/fusion/mptlan.c
+++ b/drivers/message/fusion/mptlan.c
@@ -670,7 +670,7 @@ mpt_lan_send_reply(struct net_device *dev, LANSendReply_t *pSendRep)
 }
 
 /*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/
-static int
+static netdev_tx_t
 mpt_lan_sdu_send (struct sk_buff *skb, struct net_device *dev)
 {
 	struct mpt_lan_priv *priv = netdev_priv(dev);
-- 
2.17.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mptlan: fix mpt_lan_sdu_send()'s return type
  2018-04-24 13:15 [PATCH] mptlan: fix mpt_lan_sdu_send()'s return type Luc Van Oostenryck
@ 2018-05-08  5:21 ` Martin K. Petersen
  2018-05-08 15:44   ` Luc Van Oostenryck
  0 siblings, 1 reply; 4+ messages in thread
From: Martin K. Petersen @ 2018-05-08  5:21 UTC (permalink / raw)
  To: Luc Van Oostenryck
  Cc: linux-kernel, Sathya Prakash, Chaitra P B,
	Suganath Prabu Subramani, MPT-FusionLinux.pdl, linux-scsi


Luc,

> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, but the implementation in this
> driver returns an 'int'.

You forgot to update the function prototype accordingly.

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mptlan: fix mpt_lan_sdu_send()'s return type
  2018-05-08  5:21 ` Martin K. Petersen
@ 2018-05-08 15:44   ` Luc Van Oostenryck
  2018-05-15  2:51     ` Martin K. Petersen
  0 siblings, 1 reply; 4+ messages in thread
From: Luc Van Oostenryck @ 2018-05-08 15:44 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: linux-kernel, Sathya Prakash, Chaitra P B,
	Suganath Prabu Subramani, MPT-FusionLinux.pdl, linux-scsi

On Tue, May 08, 2018 at 01:21:56AM -0400, Martin K. Petersen wrote:
> 
> Luc,
> 
> > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> > which is a typedef for an enum type, but the implementation in this
> > driver returns an 'int'.
> 
> You forgot to update the function prototype accordingly.

Hmmm, the function mpt_lan_sdu_send() has no other declaration
than the one I modified the return type in this patch.

Must be a misunderstanding somewhere.

-- Luc

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mptlan: fix mpt_lan_sdu_send()'s return type
  2018-05-08 15:44   ` Luc Van Oostenryck
@ 2018-05-15  2:51     ` Martin K. Petersen
  0 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2018-05-15  2:51 UTC (permalink / raw)
  To: Luc Van Oostenryck
  Cc: Martin K. Petersen, linux-kernel, Sathya Prakash, Chaitra P B,
	Suganath Prabu Subramani, MPT-FusionLinux.pdl, linux-scsi


Luc,

>> You forgot to update the function prototype accordingly.
>
> Hmmm, the function mpt_lan_sdu_send() has no other declaration
> than the one I modified the return type in this patch.
>
> Must be a misunderstanding somewhere.

My bad, I thought you were updating mpt_lan_send_reply().

Applied to 4.18/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-05-15  2:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-24 13:15 [PATCH] mptlan: fix mpt_lan_sdu_send()'s return type Luc Van Oostenryck
2018-05-08  5:21 ` Martin K. Petersen
2018-05-08 15:44   ` Luc Van Oostenryck
2018-05-15  2:51     ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).