LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] MIPS: sni: Remove the read_persistent_clock()
@ 2018-04-19  7:21 Baolin Wang
  2018-04-20 15:26 ` Arnd Bergmann
  2018-05-08 22:44 ` James Hogan
  0 siblings, 2 replies; 3+ messages in thread
From: Baolin Wang @ 2018-04-19  7:21 UTC (permalink / raw)
  To: ralf, jhogan
  Cc: kstewart, gregkh, tglx, pombredanne, arnd, broonie, linux-mips,
	linux-kernel, baolin.wang

The dummy read_persistent_clock() uses a timespec, which is not year 2038
safe on 32bit systems. Thus remove this obsolete interface.

Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
---
 arch/mips/sni/time.c |    6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/mips/sni/time.c b/arch/mips/sni/time.c
index 0eb7d1e..dbace1f 100644
--- a/arch/mips/sni/time.c
+++ b/arch/mips/sni/time.c
@@ -171,9 +171,3 @@ void __init plat_time_init(void)
 	}
 	setup_pit_timer();
 }
-
-void read_persistent_clock(struct timespec *ts)
-{
-	ts->tv_sec = -1;
-	ts->tv_nsec = 0;
-}
-- 
1.7.9.5

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] MIPS: sni: Remove the read_persistent_clock()
  2018-04-19  7:21 [PATCH] MIPS: sni: Remove the read_persistent_clock() Baolin Wang
@ 2018-04-20 15:26 ` Arnd Bergmann
  2018-05-08 22:44 ` James Hogan
  1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2018-04-20 15:26 UTC (permalink / raw)
  To: Baolin Wang
  Cc: Ralf Baechle, James Hogan, Kate Stewart, gregkh, Thomas Gleixner,
	Philippe Ombredanne, Mark Brown,
	open list:RALINK MIPS ARCHITECTURE, Linux Kernel Mailing List

On Thu, Apr 19, 2018 at 9:21 AM, Baolin Wang <baolin.wang@linaro.org> wrote:
> The dummy read_persistent_clock() uses a timespec, which is not year 2038
> safe on 32bit systems. Thus remove this obsolete interface.
>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>

Looks good to me. I have a larger but incomplete patch for arch/mips
handling of  read_persistent_clock(), but yours is a good start.

Acked-by: Arnd Bergmann <arnd@arndb.de>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] MIPS: sni: Remove the read_persistent_clock()
  2018-04-19  7:21 [PATCH] MIPS: sni: Remove the read_persistent_clock() Baolin Wang
  2018-04-20 15:26 ` Arnd Bergmann
@ 2018-05-08 22:44 ` James Hogan
  1 sibling, 0 replies; 3+ messages in thread
From: James Hogan @ 2018-05-08 22:44 UTC (permalink / raw)
  To: Baolin Wang
  Cc: ralf, kstewart, gregkh, tglx, pombredanne, arnd, broonie,
	linux-mips, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

On Thu, Apr 19, 2018 at 03:21:06PM +0800, Baolin Wang wrote:
> The dummy read_persistent_clock() uses a timespec, which is not year 2038
> safe on 32bit systems. Thus remove this obsolete interface.
> 
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>

Thanks, Applied for 4.18

Cheers
James

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-08 22:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-19  7:21 [PATCH] MIPS: sni: Remove the read_persistent_clock() Baolin Wang
2018-04-20 15:26 ` Arnd Bergmann
2018-05-08 22:44 ` James Hogan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).