LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Roman Gushchin <guro@fb.com>
Cc: kbuild-all@01.org, linux-mm@kvack.org, kernel-team@fb.com,
	Roman Gushchin <guro@fb.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@kernel.org>,
	Vladimir Davydov <vdavydov.dev@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH] mm: fix oom_kill event handling
Date: Wed, 9 May 2018 06:28:50 +0800	[thread overview]
Message-ID: <201805090517.qOJWEBHn%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180508120402.3159-1-guro@fb.com>

[-- Attachment #1: Type: text/plain, Size: 11415 bytes --]

Hi Roman,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mmotm/master]
[also build test ERROR on next-20180508]
[cannot apply to v4.17-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Roman-Gushchin/mm-fix-oom_kill-event-handling/20180509-051754
base:   git://git.cmpxchg.org/linux-mmotm.git master
config: x86_64-randconfig-x010-201818 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/swap.h:9:0,
                    from include/linux/suspend.h:5,
                    from arch/x86/kernel/asm-offsets.c:13:
   include/linux/memcontrol.h: In function 'memcg_memory_event_mm':
>> include/linux/memcontrol.h:746:10: error: implicit declaration of function 'mem_cgroup_from_task'; did you mean 'mem_cgroup_from_css'? [-Werror=implicit-function-declaration]
     memcg = mem_cgroup_from_task(rcu_dereference(mm->owner));
             ^~~~~~~~~~~~~~~~~~~~
             mem_cgroup_from_css
   In file included from include/linux/srcu.h:33:0,
                    from include/linux/notifier.h:16,
                    from include/linux/memory_hotplug.h:7,
                    from include/linux/mmzone.h:777,
                    from include/linux/gfp.h:6,
                    from include/linux/slab.h:15,
                    from include/linux/crypto.h:24,
                    from arch/x86/kernel/asm-offsets.c:9:
>> include/linux/memcontrol.h:746:49: error: 'struct mm_struct' has no member named 'owner'
     memcg = mem_cgroup_from_task(rcu_dereference(mm->owner));
                                                    ^
   include/linux/rcupdate.h:351:10: note: in definition of macro '__rcu_dereference_check'
     typeof(*p) *________p1 = (typeof(*p) *__force)READ_ONCE(p); \
             ^
   include/linux/rcupdate.h:546:28: note: in expansion of macro 'rcu_dereference_check'
    #define rcu_dereference(p) rcu_dereference_check(p, 0)
                               ^~~~~~~~~~~~~~~~~~~~~
>> include/linux/memcontrol.h:746:31: note: in expansion of macro 'rcu_dereference'
     memcg = mem_cgroup_from_task(rcu_dereference(mm->owner));
                                  ^~~~~~~~~~~~~~~
>> include/linux/memcontrol.h:746:49: error: 'struct mm_struct' has no member named 'owner'
     memcg = mem_cgroup_from_task(rcu_dereference(mm->owner));
                                                    ^
   include/linux/rcupdate.h:351:36: note: in definition of macro '__rcu_dereference_check'
     typeof(*p) *________p1 = (typeof(*p) *__force)READ_ONCE(p); \
                                       ^
   include/linux/rcupdate.h:546:28: note: in expansion of macro 'rcu_dereference_check'
    #define rcu_dereference(p) rcu_dereference_check(p, 0)
                               ^~~~~~~~~~~~~~~~~~~~~
>> include/linux/memcontrol.h:746:31: note: in expansion of macro 'rcu_dereference'
     memcg = mem_cgroup_from_task(rcu_dereference(mm->owner));
                                  ^~~~~~~~~~~~~~~
   In file included from arch/x86/include/asm/atomic.h:5:0,
                    from include/linux/atomic.h:5,
                    from include/linux/crypto.h:20,
                    from arch/x86/kernel/asm-offsets.c:9:
>> include/linux/memcontrol.h:746:49: error: 'struct mm_struct' has no member named 'owner'
     memcg = mem_cgroup_from_task(rcu_dereference(mm->owner));
                                                    ^
   include/linux/compiler.h:250:17: note: in definition of macro '__READ_ONCE'
     union { typeof(x) __val; char __c[1]; } __u;   \
                    ^
   include/linux/rcupdate.h:351:48: note: in expansion of macro 'READ_ONCE'
     typeof(*p) *________p1 = (typeof(*p) *__force)READ_ONCE(p); \
                                                   ^~~~~~~~~
   include/linux/rcupdate.h:488:2: note: in expansion of macro '__rcu_dereference_check'
     __rcu_dereference_check((p), (c) || rcu_read_lock_held(), __rcu)
     ^~~~~~~~~~~~~~~~~~~~~~~
   include/linux/rcupdate.h:546:28: note: in expansion of macro 'rcu_dereference_check'
    #define rcu_dereference(p) rcu_dereference_check(p, 0)
                               ^~~~~~~~~~~~~~~~~~~~~
>> include/linux/memcontrol.h:746:31: note: in expansion of macro 'rcu_dereference'
     memcg = mem_cgroup_from_task(rcu_dereference(mm->owner));
                                  ^~~~~~~~~~~~~~~
>> include/linux/memcontrol.h:746:49: error: 'struct mm_struct' has no member named 'owner'
     memcg = mem_cgroup_from_task(rcu_dereference(mm->owner));
                                                    ^
   include/linux/compiler.h:252:22: note: in definition of macro '__READ_ONCE'
      __read_once_size(&(x), __u.__c, sizeof(x));  \
                         ^
   include/linux/rcupdate.h:351:48: note: in expansion of macro 'READ_ONCE'
     typeof(*p) *________p1 = (typeof(*p) *__force)READ_ONCE(p); \
                                                   ^~~~~~~~~
   include/linux/rcupdate.h:488:2: note: in expansion of macro '__rcu_dereference_check'
     __rcu_dereference_check((p), (c) || rcu_read_lock_held(), __rcu)
     ^~~~~~~~~~~~~~~~~~~~~~~
   include/linux/rcupdate.h:546:28: note: in expansion of macro 'rcu_dereference_check'
    #define rcu_dereference(p) rcu_dereference_check(p, 0)
                               ^~~~~~~~~~~~~~~~~~~~~
>> include/linux/memcontrol.h:746:31: note: in expansion of macro 'rcu_dereference'
     memcg = mem_cgroup_from_task(rcu_dereference(mm->owner));
                                  ^~~~~~~~~~~~~~~
>> include/linux/memcontrol.h:746:49: error: 'struct mm_struct' has no member named 'owner'
     memcg = mem_cgroup_from_task(rcu_dereference(mm->owner));
                                                    ^
   include/linux/compiler.h:252:42: note: in definition of macro '__READ_ONCE'
      __read_once_size(&(x), __u.__c, sizeof(x));  \
                                             ^
   include/linux/rcupdate.h:351:48: note: in expansion of macro 'READ_ONCE'
     typeof(*p) *________p1 = (typeof(*p) *__force)READ_ONCE(p); \
                                                   ^~~~~~~~~
   include/linux/rcupdate.h:488:2: note: in expansion of macro '__rcu_dereference_check'
     __rcu_dereference_check((p), (c) || rcu_read_lock_held(), __rcu)
     ^~~~~~~~~~~~~~~~~~~~~~~
   include/linux/rcupdate.h:546:28: note: in expansion of macro 'rcu_dereference_check'
    #define rcu_dereference(p) rcu_dereference_check(p, 0)
                               ^~~~~~~~~~~~~~~~~~~~~
>> include/linux/memcontrol.h:746:31: note: in expansion of macro 'rcu_dereference'
     memcg = mem_cgroup_from_task(rcu_dereference(mm->owner));
                                  ^~~~~~~~~~~~~~~
>> include/linux/memcontrol.h:746:49: error: 'struct mm_struct' has no member named 'owner'
     memcg = mem_cgroup_from_task(rcu_dereference(mm->owner));
                                                    ^
   include/linux/compiler.h:254:30: note: in definition of macro '__READ_ONCE'
      __read_once_size_nocheck(&(x), __u.__c, sizeof(x)); \
                                 ^
   include/linux/rcupdate.h:351:48: note: in expansion of macro 'READ_ONCE'
     typeof(*p) *________p1 = (typeof(*p) *__force)READ_ONCE(p); \
                                                   ^~~~~~~~~
   include/linux/rcupdate.h:488:2: note: in expansion of macro '__rcu_dereference_check'
     __rcu_dereference_check((p), (c) || rcu_read_lock_held(), __rcu)
     ^~~~~~~~~~~~~~~~~~~~~~~
   include/linux/rcupdate.h:546:28: note: in expansion of macro 'rcu_dereference_check'
    #define rcu_dereference(p) rcu_dereference_check(p, 0)
                               ^~~~~~~~~~~~~~~~~~~~~
>> include/linux/memcontrol.h:746:31: note: in expansion of macro 'rcu_dereference'
     memcg = mem_cgroup_from_task(rcu_dereference(mm->owner));
                                  ^~~~~~~~~~~~~~~
>> include/linux/memcontrol.h:746:49: error: 'struct mm_struct' has no member named 'owner'
     memcg = mem_cgroup_from_task(rcu_dereference(mm->owner));
                                                    ^
   include/linux/compiler.h:254:50: note: in definition of macro '__READ_ONCE'
      __read_once_size_nocheck(&(x), __u.__c, sizeof(x)); \
                                                     ^
   include/linux/rcupdate.h:351:48: note: in expansion of macro 'READ_ONCE'
     typeof(*p) *________p1 = (typeof(*p) *__force)READ_ONCE(p); \
                                                   ^~~~~~~~~
   include/linux/rcupdate.h:488:2: note: in expansion of macro '__rcu_dereference_check'
     __rcu_dereference_check((p), (c) || rcu_read_lock_held(), __rcu)
     ^~~~~~~~~~~~~~~~~~~~~~~
   include/linux/rcupdate.h:546:28: note: in expansion of macro 'rcu_dereference_check'
    #define rcu_dereference(p) rcu_dereference_check(p, 0)
                               ^~~~~~~~~~~~~~~~~~~~~
>> include/linux/memcontrol.h:746:31: note: in expansion of macro 'rcu_dereference'
     memcg = mem_cgroup_from_task(rcu_dereference(mm->owner));
                                  ^~~~~~~~~~~~~~~
   In file included from include/linux/srcu.h:33:0,
                    from include/linux/notifier.h:16,
                    from include/linux/memory_hotplug.h:7,
                    from include/linux/mmzone.h:777,
                    from include/linux/gfp.h:6,
                    from include/linux/slab.h:15,
                    from include/linux/crypto.h:24,
                    from arch/x86/kernel/asm-offsets.c:9:
>> include/linux/memcontrol.h:746:49: error: 'struct mm_struct' has no member named 'owner'
     memcg = mem_cgroup_from_task(rcu_dereference(mm->owner));
                                                    ^
   include/linux/rcupdate.h:354:12: note: in definition of macro '__rcu_dereference_check'
     ((typeof(*p) __force __kernel *)(________p1)); \
               ^
   include/linux/rcupdate.h:546:28: note: in expansion of macro 'rcu_dereference_check'
    #define rcu_dereference(p) rcu_dereference_check(p, 0)
                               ^~~~~~~~~~~~~~~~~~~~~
>> include/linux/memcontrol.h:746:31: note: in expansion of macro 'rcu_dereference'
     memcg = mem_cgroup_from_task(rcu_dereference(mm->owner));
                                  ^~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors
   make[2]: *** [arch/x86/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [sub-make] Error 2

vim +746 include/linux/memcontrol.h

   736	
   737	static inline void memcg_memory_event_mm(struct mm_struct *mm,
   738						 enum memcg_memory_event event)
   739	{
   740		struct mem_cgroup *memcg;
   741	
   742		if (mem_cgroup_disabled())
   743			return;
   744	
   745		rcu_read_lock();
 > 746		memcg = mem_cgroup_from_task(rcu_dereference(mm->owner));
   747		if (likely(memcg))
   748			memcg_memory_event(memcg, event);
   749		rcu_read_unlock();
   750	}
   751	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29553 bytes --]

  parent reply	other threads:[~2018-05-08 22:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-08 12:04 Roman Gushchin
2018-05-08 12:49 ` Roman Gushchin
2018-05-08 22:28 ` kbuild test robot [this message]
2018-05-08 23:26 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201805090517.qOJWEBHn%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=guro@fb.com \
    --cc=hannes@cmpxchg.org \
    --cc=kbuild-all@01.org \
    --cc=kernel-team@fb.com \
    --cc=khlebnikov@yandex-team.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH] mm: fix oom_kill event handling' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).