From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934367AbeEIIlY (ORCPT ); Wed, 9 May 2018 04:41:24 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:43655 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934022AbeEIIlU (ORCPT ); Wed, 9 May 2018 04:41:20 -0400 X-Google-Smtp-Source: AB8JxZp6/CHp9u2rcQxusYOZ9rwMePdOSi1MZk82gnhcCd/Q7ziHoWW6DWTD0nE2B3xuBRSIkV3+sw== From: Juri Lelli To: rafael.j.wysocki@intel.com, peterz@infradead.org Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Juri Lelli , Ingo Molnar , Viresh Kumar , Claudio Scordino , Luca Abeni Subject: [PATCH] kernel/sched/cpufreq_schedutil: remove stale comment Date: Wed, 9 May 2018 10:40:51 +0200 Message-Id: <20180509084051.12107-1-juri.lelli@redhat.com> X-Mailer: git-send-email 2.14.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After commit 794a56ebd9a57 ("sched/cpufreq: Change the worker kthread to SCHED_DEADLINE") schedutil kthreads are "ignored" for a clock frequency selection point of view, so the potential corner case for RT tasks is not possible at all now. Remove the stale comment mentioning it. Signed-off-by: Juri Lelli Cc: Ingo Molnar Cc: Peter Zijlstra Cc: "Rafael J. Wysocki" Cc: Viresh Kumar Cc: Claudio Scordino Cc: Luca Abeni --- kernel/sched/cpufreq_schedutil.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c index d2c6083304b4..23ef19070137 100644 --- a/kernel/sched/cpufreq_schedutil.c +++ b/kernel/sched/cpufreq_schedutil.c @@ -396,19 +396,6 @@ static void sugov_irq_work(struct irq_work *irq_work) sg_policy = container_of(irq_work, struct sugov_policy, irq_work); - /* - * For RT tasks, the schedutil governor shoots the frequency to maximum. - * Special care must be taken to ensure that this kthread doesn't result - * in the same behavior. - * - * This is (mostly) guaranteed by the work_in_progress flag. The flag is - * updated only at the end of the sugov_work() function and before that - * the schedutil governor rejects all other frequency scaling requests. - * - * There is a very rare case though, where the RT thread yields right - * after the work_in_progress flag is cleared. The effects of that are - * neglected for now. - */ kthread_queue_work(&sg_policy->worker, &sg_policy->work); } -- 2.14.3