From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934775AbeEIMw3 (ORCPT ); Wed, 9 May 2018 08:52:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:40008 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934328AbeEIMw2 (ORCPT ); Wed, 9 May 2018 08:52:28 -0400 Date: Wed, 9 May 2018 08:52:24 -0400 From: Steven Rostedt To: changbin.du@intel.com Cc: yamada.masahiro@socionext.com, michal.lkml@markovi.net, tglx@linutronix.de, mingo@redhat.com, akpm@linux-foundation.org, rdunlap@infradead.org, x86@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, arnd@arndb.de, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH v4 4/4] asm-generic: fix build error in fix_to_virt with CONFIG_CC_OPTIMIZE_FOR_DEBUGGING Message-ID: <20180509085224.34116e36@gandalf.local.home> In-Reply-To: <1525855396-7908-5-git-send-email-changbin.du@intel.com> References: <1525855396-7908-1-git-send-email-changbin.du@intel.com> <1525855396-7908-5-git-send-email-changbin.du@intel.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 May 2018 16:43:16 +0800 changbin.du@intel.com wrote: > From: Changbin Du > > With '-Og' optimization level, GCC would not optimize a count for a loop > as a constant value. But BUILD_BUG_ON() only accept compile-time constant > values. Let's use __fix_to_virt() to avoid the error. > > arch/arm/mm/mmu.o: In function `fix_to_virt': > /home/changbin/work/linux/./include/asm-generic/fixmap.h:31: undefined reference to `__compiletime_assert_31' > Makefile:1051: recipe for target 'vmlinux' failed > make: *** [vmlinux] Error 1 Perhaps we should put this patch ahead of patch 3. Why allow it to break? Anyway, besides that, I think the series looks good. For the series: Acked-by: Steven Rostedt (VMware) -- Steve > > Signed-off-by: Changbin Du > > --- > v2: use __fix_to_virt() to fix the issue. > --- > arch/arm/mm/mmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c > index e46a6a4..c08d74e 100644 > --- a/arch/arm/mm/mmu.c > +++ b/arch/arm/mm/mmu.c > @@ -1599,7 +1599,7 @@ static void __init early_fixmap_shutdown(void) > pte_t *pte; > struct map_desc map; > > - map.virtual = fix_to_virt(i); > + map.virtual = __fix_to_virt(i); > pte = pte_offset_early_fixmap(pmd_off_k(map.virtual), map.virtual); > > /* Only i/o device mappings are supported ATM */