LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Chris Zankel <chris@zankel.net>,
Paul Mackerras <paulus@samba.org>,
Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <will.deacon@arm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Rich Felker <dalias@libc.org>, Ingo Molnar <mingo@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Max Filippov <jcmvbkbc@gmail.com>
Subject: Re: [PATCH 8/9] perf/breakpoint: Split breakpoint "check" and "commit"
Date: Wed, 9 May 2018 11:17:03 +0200 [thread overview]
Message-ID: <20180509091703.GH12217@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1525634395-23380-9-git-send-email-frederic@kernel.org>
On Sun, May 06, 2018 at 09:19:54PM +0200, Frederic Weisbecker wrote:
> arch/arm/include/asm/hw_breakpoint.h | 5 ++++-
> arch/arm/kernel/hw_breakpoint.c | 22 +++-------------------
> arch/arm64/include/asm/hw_breakpoint.h | 5 ++++-
> arch/arm64/kernel/hw_breakpoint.c | 22 +++-------------------
> arch/powerpc/include/asm/hw_breakpoint.h | 5 ++++-
> arch/powerpc/kernel/hw_breakpoint.c | 22 +++-------------------
> arch/sh/include/asm/hw_breakpoint.h | 5 ++++-
> arch/sh/kernel/hw_breakpoint.c | 22 +++-------------------
> arch/x86/include/asm/hw_breakpoint.h | 5 ++++-
> arch/x86/kernel/hw_breakpoint.c | 23 +++--------------------
> arch/xtensa/include/asm/hw_breakpoint.h | 5 ++++-
> arch/xtensa/kernel/hw_breakpoint.c | 22 +++-------------------
Because of those ^,
> kernel/events/hw_breakpoint.c | 11 ++++++-----
would it not make sense to have a prelimenary patch doing something
like:
__weak int hw_breakpoint_arch_check(struct perf_event *bp)
{
return arch_validate_hwbkpt_settings(bp);
}
__weak void hw_breakpoint_arch_commit(struct perf_event *bp)
{
}
combined with this bit:
> diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c
> index 6e28d28..6896ceeb 100644
> --- a/kernel/events/hw_breakpoint.c
> +++ b/kernel/events/hw_breakpoint.c
> @@ -402,11 +402,12 @@ int dbg_release_bp_slot(struct perf_event *bp)
>
> static int validate_hw_breakpoint(struct perf_event *bp)
> {
> - int ret;
> + int err;
>
> - ret = arch_validate_hwbkpt_settings(bp);
> - if (ret)
> - return ret;
> + err = hw_breakpoint_arch_check(bp, &bp->attr);
> + if (err)
> + return err;
> + hw_breakpoint_arch_commit(bp);
>
> if (arch_check_bp_in_kernelspace(bp)) {
> if (bp->attr.exclude_kernel)
And then convert the archs over one by one, and at the end remove the
weak thingies entirely?
next prev parent reply other threads:[~2018-05-09 9:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-06 19:19 [PATCH 0/9] breakpoint: Rework arch validation Frederic Weisbecker
2018-05-06 19:19 ` [PATCH 1/9] x86/breakpoint: Split validation into "check" and "commit" Frederic Weisbecker
2018-05-06 19:19 ` [PATCH 2/9] sh: Remove "struct arch_hw_breakpoint::name" unused field Frederic Weisbecker
2018-05-06 19:19 ` [PATCH 3/9] sh: Split breakpoint validation into "check" and "commit" Frederic Weisbecker
2018-05-06 19:19 ` [PATCH 4/9] arm: " Frederic Weisbecker
2018-05-08 11:13 ` Mark Rutland
2018-05-08 11:14 ` Mark Rutland
2018-05-09 11:32 ` Mark Rutland
2018-05-09 19:51 ` Andy Lutomirski
2018-05-11 2:37 ` Frederic Weisbecker
2018-05-15 13:35 ` Frederic Weisbecker
2018-05-06 19:19 ` [PATCH 5/9] xtensa: " Frederic Weisbecker
2018-05-06 19:19 ` [PATCH 6/9] arm64: " Frederic Weisbecker
2018-05-06 19:19 ` [PATCH 7/9] powerpc: " Frederic Weisbecker
2018-05-06 19:19 ` [PATCH 8/9] perf/breakpoint: Split breakpoint " Frederic Weisbecker
2018-05-07 0:46 ` Joel Fernandes
2018-05-15 13:53 ` Frederic Weisbecker
2018-05-15 15:18 ` Joel Fernandes
2018-05-09 9:17 ` Peter Zijlstra [this message]
2018-05-15 6:57 ` Ingo Molnar
2018-05-15 13:58 ` Frederic Weisbecker
2018-05-16 3:11 ` Frederic Weisbecker
2018-05-16 4:58 ` Andy Lutomirski
2018-05-19 2:42 ` Frederic Weisbecker
2018-05-06 19:19 ` [PATCH 9/9] perf/breakpoint: Only commit breakpoint to arch upon slot reservation success Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180509091703.GH12217@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=chris@zankel.net \
--cc=dalias@libc.org \
--cc=frederic@kernel.org \
--cc=jcmvbkbc@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=ysato@users.sourceforge.jp \
--subject='Re: [PATCH 8/9] perf/breakpoint: Split breakpoint "check" and "commit"' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).