LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2] hv_netvsc: Fix net device attach on older Windows hosts
@ 2018-05-09  8:17 Mohammed Gamal
  2018-05-09 15:07 ` Stephen Hemminger
  2018-05-10 19:37 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Mohammed Gamal @ 2018-05-09  8:17 UTC (permalink / raw)
  To: netdev, sthemmin
  Cc: kys, haiyangz, devel, vkuznets, linux-kernel, Mohammed Gamal

On older windows hosts the net_device instance is returned to
the caller of rndis_filter_device_add() without having the presence
bit set first. This would cause any subsequent calls to network device
operations (e.g. MTU change, channel change) to fail after the device
is detached once, returning -ENODEV.

Instead of returning the device instabce, we take the exit path where
we call netif_device_attach()

Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic")

Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
---
 drivers/net/hyperv/rndis_filter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
index 6b127be..e7ca5b5 100644
--- a/drivers/net/hyperv/rndis_filter.c
+++ b/drivers/net/hyperv/rndis_filter.c
@@ -1288,7 +1288,7 @@ struct netvsc_device *rndis_filter_device_add(struct hv_device *dev,
 		   rndis_device->link_state ? "down" : "up");
 
 	if (net_device->nvsp_version < NVSP_PROTOCOL_VERSION_5)
-		return net_device;
+		goto out;
 
 	rndis_filter_query_link_speed(rndis_device, net_device);
 
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] hv_netvsc: Fix net device attach on older Windows hosts
  2018-05-09  8:17 [PATCH v2] hv_netvsc: Fix net device attach on older Windows hosts Mohammed Gamal
@ 2018-05-09 15:07 ` Stephen Hemminger
  2018-05-10 19:37 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2018-05-09 15:07 UTC (permalink / raw)
  To: Mohammed Gamal; +Cc: netdev, sthemmin, haiyangz, linux-kernel, devel, vkuznets

On Wed,  9 May 2018 10:17:34 +0200
Mohammed Gamal <mgamal@redhat.com> wrote:

> On older windows hosts the net_device instance is returned to
> the caller of rndis_filter_device_add() without having the presence
> bit set first. This would cause any subsequent calls to network device
> operations (e.g. MTU change, channel change) to fail after the device
> is detached once, returning -ENODEV.
> 
> Instead of returning the device instabce, we take the exit path where
> we call netif_device_attach()
> 
> Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic")
> 
> Signed-off-by: Mohammed Gamal <mgamal@redhat.com>

The standard for patch submission is no blank lines between Fixes
and Signed-off-by to make it easier for bots.

> ---
>  drivers/net/hyperv/rndis_filter.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
> index 6b127be..e7ca5b5 100644
> --- a/drivers/net/hyperv/rndis_filter.c
> +++ b/drivers/net/hyperv/rndis_filter.c
> @@ -1288,7 +1288,7 @@ struct netvsc_device *rndis_filter_device_add(struct hv_device *dev,
>  		   rndis_device->link_state ? "down" : "up");
>  
>  	if (net_device->nvsp_version < NVSP_PROTOCOL_VERSION_5)
> -		return net_device;
> +		goto out;
>  
>  	rndis_filter_query_link_speed(rndis_device, net_device);
>  


Reviewed-by: Stephen Hemminger <sthemmin@microsoft.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] hv_netvsc: Fix net device attach on older Windows hosts
  2018-05-09  8:17 [PATCH v2] hv_netvsc: Fix net device attach on older Windows hosts Mohammed Gamal
  2018-05-09 15:07 ` Stephen Hemminger
@ 2018-05-10 19:37 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-05-10 19:37 UTC (permalink / raw)
  To: mgamal; +Cc: netdev, sthemmin, kys, haiyangz, devel, vkuznets, linux-kernel

From: Mohammed Gamal <mgamal@redhat.com>
Date: Wed,  9 May 2018 10:17:34 +0200

> On older windows hosts the net_device instance is returned to
> the caller of rndis_filter_device_add() without having the presence
> bit set first. This would cause any subsequent calls to network device
> operations (e.g. MTU change, channel change) to fail after the device
> is detached once, returning -ENODEV.
> 
> Instead of returning the device instabce, we take the exit path where
> we call netif_device_attach()
> 
> Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic")
> 
> Signed-off-by: Mohammed Gamal <mgamal@redhat.com>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-10 19:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-09  8:17 [PATCH v2] hv_netvsc: Fix net device attach on older Windows hosts Mohammed Gamal
2018-05-09 15:07 ` Stephen Hemminger
2018-05-10 19:37 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).