LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: arnd@arndb.de
Cc: gregkh@linuxfoundation.org, willy@infradead.org,
geert@linux-m68k.org, linux-m68k@lists.linux-m68k.org,
linux-arch@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
"Luis R. Rodriguez" <mcgrof@kernel.org>
Subject: [PATCH v2 2/2] mm: provide a fallback for PAGE_KERNEL_EXEC for architectures
Date: Wed, 9 May 2018 18:44:47 -0700 [thread overview]
Message-ID: <20180510014447.15989-3-mcgrof@kernel.org> (raw)
In-Reply-To: <20180510014447.15989-1-mcgrof@kernel.org>
Some architectures just don't have PAGE_KERNEL_EXEC. The mm/nommu.c
and mm/vmalloc.c code have been using PAGE_KERNEL as a fallback for years.
Move this fallback to asm-generic.
Architectures which do not define PAGE_KERNEL_EXEC yet:
o alpha
o mips
o openrisc
o sparc64
Suggested-by: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
include/asm-generic/pgtable.h | 12 ++++++++++++
mm/nommu.c | 4 ----
mm/vmalloc.c | 4 ----
3 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h
index 890fc54f4713..39e9bd66c786 100644
--- a/include/asm-generic/pgtable.h
+++ b/include/asm-generic/pgtable.h
@@ -1107,6 +1107,18 @@ static inline void init_espfix_bsp(void) { }
# define PAGE_KERNEL_RO PAGE_KERNEL
#endif
+/*
+ * Current architectures known to not define PAGE_KERNEL_EXEC:
+ *
+ * o alpha
+ * o mips
+ * o openrisc
+ * o sparc64
+ */
+#ifndef PAGE_KERNEL_EXEC
+# define PAGE_KERNEL_EXEC PAGE_KERNEL
+#endif
+
#endif /* !__ASSEMBLY__ */
#ifndef io_remap_pfn_range
diff --git a/mm/nommu.c b/mm/nommu.c
index 13723736d38f..08ad4dcd281d 100644
--- a/mm/nommu.c
+++ b/mm/nommu.c
@@ -364,10 +364,6 @@ void *vzalloc_node(unsigned long size, int node)
}
EXPORT_SYMBOL(vzalloc_node);
-#ifndef PAGE_KERNEL_EXEC
-# define PAGE_KERNEL_EXEC PAGE_KERNEL
-#endif
-
/**
* vmalloc_exec - allocate virtually contiguous, executable memory
* @size: allocation size
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index ebff729cc956..89543d13e32a 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -1920,10 +1920,6 @@ void *vzalloc_node(unsigned long size, int node)
}
EXPORT_SYMBOL(vzalloc_node);
-#ifndef PAGE_KERNEL_EXEC
-# define PAGE_KERNEL_EXEC PAGE_KERNEL
-#endif
-
/**
* vmalloc_exec - allocate virtually contiguous, executable memory
* @size: allocation size
--
2.17.0
next prev parent reply other threads:[~2018-05-10 1:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 1:44 [PATCH v2 0/2] mm: PAGE_KERNEL_* fallbacks Luis R. Rodriguez
2018-05-10 1:44 ` [PATCH v2 1/2] mm: provide a fallback for PAGE_KERNEL_RO for architectures Luis R. Rodriguez
2018-05-10 1:44 ` Luis R. Rodriguez [this message]
2018-05-10 7:45 ` [PATCH v2 2/2] mm: provide a fallback for PAGE_KERNEL_EXEC " Geert Uytterhoeven
2018-05-10 15:33 ` Luis R. Rodriguez
2018-05-10 17:14 ` Luis R. Rodriguez
2018-05-10 6:07 ` [PATCH v2 0/2] mm: PAGE_KERNEL_* fallbacks Greg KH
2018-05-10 17:15 ` Luis R. Rodriguez
2018-05-14 14:23 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180510014447.15989-3-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
--subject='Re: [PATCH v2 2/2] mm: provide a fallback for PAGE_KERNEL_EXEC for architectures' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).