LKML Archive on
help / color / mirror / Atom feed
From: "Jonathan Neuschäfer" <>
	"Segher Boessenkool" <>,
	"Joel Stanley" <>,
	"Benjamin Herrenschmidt" <>,
	"Paul Mackerras" <>,
	"Michael Ellerman" <>,
	"Mathieu Malaterre" <>,
	"Jonathan Neuschäfer" <>
Subject: [PATCH 2/2] powerpc: hlwd-pic: Prevent interrupts from being handled by Starlet
Date: Thu, 10 May 2018 23:59:19 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

The interrupt controller inside the Wii's Hollywood chip is connected to
two masters, the "Broadway" PowerPC and the "Starlet" ARM926, each with
their own interrupt status and mask registers.

When booting the Wii with mini[1], interrupts from the SD card
controller (IRQ 7) are handled by the ARM, because mini provides SD
access over IPC. Linux however can't currently use or disable this IPC
service, so both sides try to handle IRQ 7 without coordination.

Let's instead make sure that all interrupts that are unmasked on the PPC
side are masked on the ARM side; this will also make sure that Linux can
properly talk to the SD card controller (and potentially other devices).

If access to a device through IPC is desired in the future, interrupts
from that device should not be handled by Linux directly.


Signed-off-by: Jonathan Neuschäfer <>
 arch/powerpc/platforms/embedded6xx/hlwd-pic.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
index e3e3af73e9d8..8112b39879d6 100644
--- a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
+++ b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
@@ -35,6 +35,8 @@
 #define HW_BROADWAY_ICR		0x00
 #define HW_BROADWAY_IMR		0x04
+#define HW_STARLET_ICR		0x08
+#define HW_STARLET_IMR		0x0c
@@ -74,6 +76,9 @@ static void hlwd_pic_unmask(struct irq_data *d)
 	void __iomem *io_base = irq_data_get_irq_chip_data(d);
 	setbits32(io_base + HW_BROADWAY_IMR, 1 << irq);
+	/* Make sure the ARM (aka. Starlet) doesn't handle this interrupt. */
+	clrbits32(io_base + HW_STARLET_IMR, 1 << irq);

      parent reply	other threads:[~2018-05-10 21:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-10 21:59 [PATCH 0/2] powerpc: Wii IRQ fixes Jonathan Neuschäfer
2018-05-10 21:59 ` [PATCH 1/2] powerpc: flipper-pic: Don't match all IRQ domains Jonathan Neuschäfer
2018-05-21 10:01   ` [1/2] " Michael Ellerman
2018-05-10 21:59 ` Jonathan Neuschäfer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 2/2] powerpc: hlwd-pic: Prevent interrupts from being handled by Starlet' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).