LKML Archive on
help / color / mirror / Atom feed
From: kbuild test robot <>
To: Steve French <>
	Ronnie Sahlberg <>,
	Pavel Shilovsky <>,
Subject: [RFC PATCH cifs] smb3: cifs_dir_fsync() can be static
Date: Fri, 11 May 2018 08:50:26 +0800	[thread overview]
Message-ID: <20180511005026.GA57926@lkp-sb04> (raw)
In-Reply-To: <>

Fixes: c3d5c2a93abf ("smb3: directory sync should not return an error")
Signed-off-by: Fengguang Wu <>
 cifsfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
index 8e41186..62f1662 100644
--- a/fs/cifs/cifsfs.c
+++ b/fs/cifs/cifsfs.c
@@ -1053,7 +1053,7 @@ ssize_t cifs_file_copychunk_range(unsigned int xid,
  * Directory operations under CIFS/SMB2/SMB3 are synchronous, so fsync()
  * is a dummy operation.
-int cifs_dir_fsync(struct file *file, loff_t start, loff_t end, int datasync)
+static int cifs_dir_fsync(struct file *file, loff_t start, loff_t end, int datasync)
 	cifs_dbg(FYI, "Sync directory - name: %pD datasync: 0x%x\n",
 		 file, datasync);

      reply	other threads:[~2018-05-11  0:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-11  0:50 [cifs:for-next 12/12] fs/cifs/cifsfs.c:1056:5: sparse: symbol 'cifs_dir_fsync' was not declared. Should it be static? kbuild test robot
2018-05-11  0:50 ` kbuild test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180511005026.GA57926@lkp-sb04 \ \ \ \ \ \ \ \ \
    --subject='Re: [RFC PATCH cifs] smb3: cifs_dir_fsync() can be static' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).