LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Rafał Miłecki" <zajec5@gmail.com>
To: "Kalle Valo" <kvalo@codeaurora.org>, "Michael Büsch" <m@bues.ch>,
	"Larry Finger" <larry.finger@lwfinger.net>,
	"Matt Redfearn" <matt.redfearn@mips.com>
Cc: linux-wireless@vger.kernel.org,
	"Hauke Mehrtens" <hauke@hauke-m.de>,
	LKML <linux-kernel@vger.kernel.org>,
	"Rafał Miłecki" <rafal@milecki.pl>
Subject: [PATCH V2 1/2] Revert "ssb: Prevent build of PCI host features in module"
Date: Fri, 11 May 2018 11:17:14 +0200	[thread overview]
Message-ID: <20180511091715.1989-1-zajec5@gmail.com> (raw)

From: Rafał Miłecki <rafal@milecki.pl>

This reverts commit 882164a4a928bcaa53280940436ca476e6b1db8e.

Above commit added "SSB = y" dependency to the wrong symbol
SSB_DRIVER_PCICORE_POSSIBLE and prevented SSB_DRIVER_PCICORE from being
selected when needed. PCI core driver for core running in clienthost
mode is important for bus initialization. It's perfectly valid scenario
to have ssb built as module and use it with buses on PCI cards.

This fixes regression that affected all *module* users with PCI cards.

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1572349
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 drivers/ssb/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
index 9371651d8017..b3f5cae98ea6 100644
--- a/drivers/ssb/Kconfig
+++ b/drivers/ssb/Kconfig
@@ -117,7 +117,7 @@ config SSB_SERIAL
 
 config SSB_DRIVER_PCICORE_POSSIBLE
 	bool
-	depends on SSB_PCIHOST && SSB = y
+	depends on SSB_PCIHOST
 	default y
 
 config SSB_DRIVER_PCICORE
-- 
2.13.6

             reply	other threads:[~2018-05-11  9:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-11  9:17 Rafał Miłecki [this message]
2018-05-11  9:17 ` [PATCH V2 2/2] ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y Rafał Miłecki
2018-05-11  9:21 ` [PATCH V2 1/2] Revert "ssb: Prevent build of PCI host features in module" Rafał Miłecki
2018-05-11 10:13   ` Kalle Valo
2018-05-11 10:25     ` Rafał Miłecki
2018-05-11 12:08     ` Larry Finger
2018-05-12  7:50       ` Kalle Valo
2018-05-12  8:01         ` Michael Büsch
2018-05-12 10:00           ` Rafał Miłecki
2018-05-12 10:14             ` Michael Büsch
2018-05-12  8:40 ` [V2, " Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180511091715.1989-1-zajec5@gmail.com \
    --to=zajec5@gmail.com \
    --cc=hauke@hauke-m.de \
    --cc=kvalo@codeaurora.org \
    --cc=larry.finger@lwfinger.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=m@bues.ch \
    --cc=matt.redfearn@mips.com \
    --cc=rafal@milecki.pl \
    --subject='Re: [PATCH V2 1/2] Revert "ssb: Prevent build of PCI host features in module"' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).