LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2] vfio: platform: Make printed error messages more consistent
@ 2018-04-10 14:54 Geert Uytterhoeven
  2018-04-13  8:54 ` Auger Eric
  2018-05-11 19:45 ` Alex Williamson
  0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2018-04-10 14:54 UTC (permalink / raw)
  To: Baptiste Reynal, Alex Williamson; +Cc: kvm, linux-kernel, Geert Uytterhoeven

  - Capitalize the first word of error messages,
  - Unwrap statements that fit on a single line,
  - Use "VFIO" instead of "vfio" as the error message prefix.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
---
v2:
  - Add Reviewed-by.
---
 drivers/vfio/platform/vfio_platform_common.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
index 4c27f4be3c3d0385..35469af87f88678e 100644
--- a/drivers/vfio/platform/vfio_platform_common.c
+++ b/drivers/vfio/platform/vfio_platform_common.c
@@ -630,8 +630,7 @@ static int vfio_platform_of_probe(struct vfio_platform_device *vdev,
 	ret = device_property_read_string(dev, "compatible",
 					  &vdev->compat);
 	if (ret)
-		pr_err("VFIO: cannot retrieve compat for %s\n",
-			vdev->name);
+		pr_err("VFIO: Cannot retrieve compat for %s\n", vdev->name);
 
 	return ret;
 }
@@ -673,7 +672,7 @@ int vfio_platform_probe_common(struct vfio_platform_device *vdev,
 
 	ret = vfio_platform_get_reset(vdev);
 	if (ret && vdev->reset_required) {
-		pr_err("vfio: no reset function found for device %s\n",
+		pr_err("VFIO: No reset function found for device %s\n",
 		       vdev->name);
 		return ret;
 	}
-- 
2.7.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] vfio: platform: Make printed error messages more consistent
  2018-04-10 14:54 [PATCH v2] vfio: platform: Make printed error messages more consistent Geert Uytterhoeven
@ 2018-04-13  8:54 ` Auger Eric
  2018-05-11 19:45 ` Alex Williamson
  1 sibling, 0 replies; 3+ messages in thread
From: Auger Eric @ 2018-04-13  8:54 UTC (permalink / raw)
  To: Geert Uytterhoeven, Baptiste Reynal, Alex Williamson; +Cc: kvm, linux-kernel

Hi Geert,On 10/04/18 16:54, Geert Uytterhoeven wrote:
>   - Capitalize the first word of error messages,
>   - Unwrap statements that fit on a single line,
>   - Use "VFIO" instead of "vfio" as the error message prefix.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Eric Auger <eric.auger@redhat.com>
Acked-by: Eric Auger <eric.auger@redhat.com>

Thanks

Eric
> ---
> v2:
>   - Add Reviewed-by.
> ---
>  drivers/vfio/platform/vfio_platform_common.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
> index 4c27f4be3c3d0385..35469af87f88678e 100644
> --- a/drivers/vfio/platform/vfio_platform_common.c
> +++ b/drivers/vfio/platform/vfio_platform_common.c
> @@ -630,8 +630,7 @@ static int vfio_platform_of_probe(struct vfio_platform_device *vdev,
>  	ret = device_property_read_string(dev, "compatible",
>  					  &vdev->compat);
>  	if (ret)
> -		pr_err("VFIO: cannot retrieve compat for %s\n",
> -			vdev->name);
> +		pr_err("VFIO: Cannot retrieve compat for %s\n", vdev->name);
>  
>  	return ret;
>  }
> @@ -673,7 +672,7 @@ int vfio_platform_probe_common(struct vfio_platform_device *vdev,
>  
>  	ret = vfio_platform_get_reset(vdev);
>  	if (ret && vdev->reset_required) {
> -		pr_err("vfio: no reset function found for device %s\n",
> +		pr_err("VFIO: No reset function found for device %s\n",
>  		       vdev->name);
>  		return ret;
>  	}
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] vfio: platform: Make printed error messages more consistent
  2018-04-10 14:54 [PATCH v2] vfio: platform: Make printed error messages more consistent Geert Uytterhoeven
  2018-04-13  8:54 ` Auger Eric
@ 2018-05-11 19:45 ` Alex Williamson
  1 sibling, 0 replies; 3+ messages in thread
From: Alex Williamson @ 2018-05-11 19:45 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Baptiste Reynal, kvm, linux-kernel

On Tue, 10 Apr 2018 16:54:11 +0200
Geert Uytterhoeven <geert+renesas@glider.be> wrote:

>   - Capitalize the first word of error messages,
>   - Unwrap statements that fit on a single line,
>   - Use "VFIO" instead of "vfio" as the error message prefix.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Eric Auger <eric.auger@redhat.com>
> ---
> v2:
>   - Add Reviewed-by.
> ---
>  drivers/vfio/platform/vfio_platform_common.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Applied to next branch for v4.18 with Eric's ack, Thanks,

Alex

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-11 19:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-10 14:54 [PATCH v2] vfio: platform: Make printed error messages more consistent Geert Uytterhoeven
2018-04-13  8:54 ` Auger Eric
2018-05-11 19:45 ` Alex Williamson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).