LKML Archive on
help / color / mirror / Atom feed
From: Bjorn Helgaas <>
To: Keith Busch <>
Cc: Jesse Vincent <>, Sagi Grimberg <>,, Andrew Lutomirski <>,,,
	Jens Axboe <>, Bjorn Helgaas <>,
	Christoph Hellwig <>
Subject: Re: Another NVMe failure, this time with AER info
Date: Fri, 11 May 2018 12:55:38 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20180511174241.GC7344@localhost.localdomain>

On Fri, May 11, 2018 at 11:42:42AM -0600, Keith Busch wrote:
> On Fri, May 11, 2018 at 11:26:11AM -0600, Keith Busch wrote:
> > I trust you know the offsets here, but it's hard to tell what this
> > is doing with hard-coded addresses. Just to be safe and for clarity,
> > I recommend the 'CAP_*+<offset>' with a mask.
> > 
> > For example, disabling ASPM L1.2 can look like:
> > 
> >  # setpci -s <B:D.f> CAP_PM+8.l=0:4
> My mistake above: CAP_PM is a different capability, not the intended
> one. It looks like setpci doesn't even have a convenient symbol for the
> L1 PM extended capability, so the hard-coded offsets are the only way
> for this setting. Sorry about the mistake.

No problem, would be a nice janitor job to add more of those symbolic
offsets to setpci.  I recently added more cap ID decoding to lspci, but
didn't think about updating these things for setpci.

Using the symbols would definitely make this easier and better!

  reply	other threads:[~2018-05-11 17:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2018-05-11 16:57 ` Bjorn Helgaas
2018-05-11 17:26   ` Keith Busch
2018-05-11 17:42     ` Keith Busch
2018-05-11 17:55       ` Bjorn Helgaas [this message]
2018-05-12  2:38   ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: Another NVMe failure, this time with AER info' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).