LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] staging: lustre: Use 'kvfree()' for memory allocated by 'kvzalloc()'
@ 2018-05-12 12:14 Christophe JAILLET
  2018-05-12 21:31 ` NeilBrown
  0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2018-05-12 12:14 UTC (permalink / raw)
  To: oleg.drokin, andreas.dilger, jsimmons, gregkh, neilb, aastha.gupta4104
  Cc: lustre-devel, devel, linux-kernel, kernel-janitors, Christophe JAILLET

'buf' is allocated with 'kvzalloc()'. 'kvfree()' must be used to free it.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Fixes: 11c647caf74b ("staging: lustre: obdclass: variable llog chunk size")
Reviewed-by: NeilBrown <neilb@suse.com>
---
 drivers/staging/lustre/lustre/obdclass/llog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/obdclass/llog.c b/drivers/staging/lustre/lustre/obdclass/llog.c
index 693e1129f1f9..5e04d133b596 100644
--- a/drivers/staging/lustre/lustre/obdclass/llog.c
+++ b/drivers/staging/lustre/lustre/obdclass/llog.c
@@ -385,7 +385,7 @@ static int llog_process_thread(void *arg)
 	if (cd)
 		cd->lpcd_last_idx = last_called_index;
 
-	kfree(buf);
+	kvfree(buf);
 	lpi->lpi_rc = rc;
 	return 0;
 }
-- 
2.17.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: lustre: Use 'kvfree()' for memory allocated by 'kvzalloc()'
  2018-05-12 12:14 [PATCH] staging: lustre: Use 'kvfree()' for memory allocated by 'kvzalloc()' Christophe JAILLET
@ 2018-05-12 21:31 ` NeilBrown
  0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2018-05-12 21:31 UTC (permalink / raw)
  To: Christophe JAILLET, oleg.drokin, andreas.dilger, jsimmons,
	gregkh, aastha.gupta4104
  Cc: devel, Christophe JAILLET, kernel-janitors, linux-kernel, lustre-devel


[-- Attachment #1.1: Type: text/plain, Size: 999 bytes --]

On Sat, May 12 2018, Christophe JAILLET wrote:

> 'buf' is allocated with 'kvzalloc()'. 'kvfree()' must be used to free it.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Reviewed-by: NeilBrown <neilb@suse.com>

Thanks.
We could possible add:
Fixes: 11c647caf74b ("staging: lustre: obdclass: variable llog chunk size")

just for completeness.

NeilBrown

> ---
>  drivers/staging/lustre/lustre/obdclass/llog.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/llog.c b/drivers/staging/lustre/lustre/obdclass/llog.c
> index 693e1129f1f9..5e04d133b596 100644
> --- a/drivers/staging/lustre/lustre/obdclass/llog.c
> +++ b/drivers/staging/lustre/lustre/obdclass/llog.c
> @@ -385,7 +385,7 @@ static int llog_process_thread(void *arg)
>  	if (cd)
>  		cd->lpcd_last_idx = last_called_index;
>  
> -	kfree(buf);
> +	kvfree(buf);
>  	lpi->lpi_rc = rc;
>  	return 0;
>  }
> -- 
> 2.17.0

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 169 bytes --]

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-05-12 21:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-12 12:14 [PATCH] staging: lustre: Use 'kvfree()' for memory allocated by 'kvzalloc()' Christophe JAILLET
2018-05-12 21:31 ` NeilBrown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).