LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] libata: Apply NOLPM quirk for SAMSUNG PM830 CXM13D1Q.
@ 2018-05-13 18:11 fcami
  2018-05-14 15:32 ` Tejun Heo
  0 siblings, 1 reply; 2+ messages in thread
From: fcami @ 2018-05-13 18:11 UTC (permalink / raw)
  To: tj, hdegoede, linux-kernel, linux-ide; +Cc: François Cami

From: François Cami <fcami@fedoraproject.org>

Without this patch the drive errors out regularly:

[    1.090154] ata1.00: ATA-8: SAMSUNG SSD PM830 mSATA 256GB,
CXM13D1Q, max UDMA/133
(...)
[  345.154996] ata1.00: exception Emask 0x40 SAct 0x0 SErr 0xc0800 action 0x6
[  345.155006] ata1.00: irq_stat 0x40000001
[  345.155013] ata1: SError: { HostInt CommWake 10B8B }
[  345.155018] ata1.00: failed command: SET FEATURES
[  345.155032] ata1.00: cmd ef/05:e1:00:00:00/00:00:00:00:00/40 tag 7
                        res 51/04:e1:00:00:00/00:00:00:00:00/40 Emask 0x41 (internal error)
[  345.155038] ata1.00: status: { DRDY ERR }
[  345.155042] ata1.00: error: { ABRT }
[  345.155051] ata1: hard resetting link
[  345.465661] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
[  345.466955] ata1.00: configured for UDMA/133
[  345.467085] ata1: EH complete

Signed-off-by: François Cami <fcami@fedoraproject.org>
Acked-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/ata/libata-core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 68596bd4cf06..1ca365f13040 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4549,8 +4549,9 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 						ATA_HORKAGE_ZERO_AFTER_TRIM |
 						ATA_HORKAGE_NOLPM, },
 
-	/* This specific Samsung model/firmware-rev does not handle LPM well */
+	/* These specific Samsung models/firmware-revs do not handle LPM well */
 	{ "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
+	{ "SAMSUNG SSD PM830 mSATA *",  "CXM13D1Q", ATA_HORKAGE_NOLPM, },
 
 	/* Sandisk devices which are known to not handle LPM well */
 	{ "SanDisk SD7UB3Q*G1001",	NULL,	ATA_HORKAGE_NOLPM, },
-- 
2.17.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] libata: Apply NOLPM quirk for SAMSUNG PM830 CXM13D1Q.
  2018-05-13 18:11 [PATCH] libata: Apply NOLPM quirk for SAMSUNG PM830 CXM13D1Q fcami
@ 2018-05-14 15:32 ` Tejun Heo
  0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2018-05-14 15:32 UTC (permalink / raw)
  To: fcami; +Cc: hdegoede, linux-kernel, linux-ide

On Sun, May 13, 2018 at 08:11:15PM +0200, fcami@fedoraproject.org wrote:
> From: François Cami <fcami@fedoraproject.org>
> 
> Without this patch the drive errors out regularly:
> 
> [    1.090154] ata1.00: ATA-8: SAMSUNG SSD PM830 mSATA 256GB,
> CXM13D1Q, max UDMA/133
> (...)
> [  345.154996] ata1.00: exception Emask 0x40 SAct 0x0 SErr 0xc0800 action 0x6
> [  345.155006] ata1.00: irq_stat 0x40000001
> [  345.155013] ata1: SError: { HostInt CommWake 10B8B }
> [  345.155018] ata1.00: failed command: SET FEATURES
> [  345.155032] ata1.00: cmd ef/05:e1:00:00:00/00:00:00:00:00/40 tag 7
>                         res 51/04:e1:00:00:00/00:00:00:00:00/40 Emask 0x41 (internal error)
> [  345.155038] ata1.00: status: { DRDY ERR }
> [  345.155042] ata1.00: error: { ABRT }
> [  345.155051] ata1: hard resetting link
> [  345.465661] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
> [  345.466955] ata1.00: configured for UDMA/133
> [  345.467085] ata1: EH complete
> 
> Signed-off-by: François Cami <fcami@fedoraproject.org>
> Acked-by: Hans de Goede <hdegoede@redhat.com>

Applied to libata/for-4.17-fixes.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-05-14 15:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-13 18:11 [PATCH] libata: Apply NOLPM quirk for SAMSUNG PM830 CXM13D1Q fcami
2018-05-14 15:32 ` Tejun Heo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).