LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>,
	viro@zeniv.linux.org.uk, darrick.wong@oracle.com,
	adilger.kernel@dilger.ca, clm@fb.com, jbacik@fb.com,
	dsterba@suse.com, sandeen@sandeen.net, dhowells@redhat.com,
	fliu@suse.com, jeffm@suse.com, nborisov@suse.com,
	jake.norris@suse.com, mtk.manpages@gmail.com,
	linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC v2 3/4] ext4: add verifier check for symlink with append/immutable flags
Date: Sun, 13 May 2018 16:51:32 -0400	[thread overview]
Message-ID: <20180513205132.GG14763@thunk.org> (raw)
In-Reply-To: <20180511211218.rs365ftuw53c4qj2@quack2.suse.cz>

On Fri, May 11, 2018 at 11:12:18PM +0200, Jan Kara wrote:
> On Thu 10-05-18 16:13:58, Luis R. Rodriguez wrote:
> > The Linux VFS does not allow a way to set append/immuttable
> > attributes to symlinks, this is just not possible. If this is
> > detected inform the user as the filesystem must be corrupted.
> > 
> > Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
> 
> Looks good to me. You can add:
> 
> Reviewed-by: Jan Kara <jack@suse.cz>

Applied into the ext4 tree after verifying that e2fsck already handles
this case:

% e2fsck -fy /tmp/foo.img
e2fsck 1.44.1 (24-Mar-2018)
Pass 1: Checking inodes, blocks, and sizes
Special (device/socket/fifo/symlink) file (inode 13) has immutable
or append-only flag set.  Clear? yes

(The btrfs and xfs maintainers might want to make a similar check
before accepting their respective patches.)

						- Ted

  reply	other threads:[~2018-05-13 20:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-10 23:13 [RFC v2 0/4] vfs: detect symlink corruption with attributes Luis R. Rodriguez
2018-05-10 23:13 ` [RFC v2 1/4] vfs: skip extra attributes check on removal for symlinks Luis R. Rodriguez
2018-05-10 23:13 ` [RFC v2 2/4] xfs: add verifier check for symlink with append/immutable flags Luis R. Rodriguez
2018-05-11  2:20   ` Darrick J. Wong
2018-05-10 23:13 ` [RFC v2 3/4] ext4: " Luis R. Rodriguez
2018-05-11 21:12   ` Jan Kara
2018-05-13 20:51     ` Theodore Y. Ts'o [this message]
2018-05-10 23:13 ` [RFC v2 4/4] btrfs: verify symlinks " Luis R. Rodriguez
2018-05-11 14:04   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180513205132.GG14763@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=clm@fb.com \
    --cc=darrick.wong@oracle.com \
    --cc=dhowells@redhat.com \
    --cc=dsterba@suse.com \
    --cc=fliu@suse.com \
    --cc=jack@suse.cz \
    --cc=jake.norris@suse.com \
    --cc=jbacik@fb.com \
    --cc=jeffm@suse.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=nborisov@suse.com \
    --cc=sandeen@sandeen.net \
    --cc=viro@zeniv.linux.org.uk \
    --subject='Re: [RFC v2 3/4] ext4: add verifier check for symlink with append/immutable flags' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).