LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>,
	Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
	Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
	"David S . Miller" <davem@davemloft.net>,
	Josef Bacik <jbacik@fb.com>, Alexei Starovoitov <ast@kernel.org>
Subject: Re: [RFC PATCH -tip 2/4] kprobes: Remove jprobe generic code
Date: Mon, 14 May 2018 09:03:36 +0900	[thread overview]
Message-ID: <20180514090336.e6f3ec9e750cc14faf38714c@kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.21.1805132154220.1582@nanos.tec.linutronix.de>

On Sun, 13 May 2018 21:55:38 +0200 (CEST)
Thomas Gleixner <tglx@linutronix.de> wrote:

> On Tue, 8 May 2018, Masami Hiramatsu wrote:
> 
> > Remove jprobe arch independent generic code
> > from kernel/kprobes.c.
> 
> # git grep register_jprobes
> include/linux/kprobes.h:static inline int register_jprobes(struct jprobe **jps, int num)
> include/linux/kprobes.h:static inline void unregister_jprobes(struct jprobe **jps, int num)
> kernel/test_kprobes.c:  ret = register_jprobes(jps, 2);
> kernel/test_kprobes.c:          pr_err("register_jprobes returned %d\n", ret);
> kernel/test_kprobes.c:  unregister_jprobes(jps, 2);
> 
> You forgot to remove a few things ...

Ah, thoes are already disabled (with #if 0) but it is better to remove it first.

Thanks!

> 
> Thanks,
> 
> 	tglx


-- 
Masami Hiramatsu <mhiramat@kernel.org>

  reply	other threads:[~2018-05-14  0:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-08 13:36 [RFC PATCH -tip 0/4] kprobes: x86: Remove jprobes related code Masami Hiramatsu
2018-05-08 13:36 ` [RFC PATCH -tip 1/4] Documentation/kprobes: Fix to remove remaining jprobe Masami Hiramatsu
2018-05-08 13:37 ` [RFC PATCH -tip 2/4] kprobes: Remove jprobe generic code Masami Hiramatsu
2018-05-13 19:55   ` Thomas Gleixner
2018-05-14  0:03     ` Masami Hiramatsu [this message]
2018-05-08 13:37 ` [RFC PATCH -tip 3/4] kprobes: x86: Remove jprobe x86 port Masami Hiramatsu
2018-05-08 13:38 ` [RFC PATCH -tip 4/4] bpf: error-inject: x86: Fix unbalanced preempt-count for function override Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180514090336.e6f3ec9e750cc14faf38714c@kernel.org \
    --to=mhiramat@kernel.org \
    --cc=ananth@linux.vnet.ibm.com \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=ast@kernel.org \
    --cc=davem@davemloft.net \
    --cc=jbacik@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=ravi.bangoria@linux.vnet.ibm.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --subject='Re: [RFC PATCH -tip 2/4] kprobes: Remove jprobe generic code' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).