LKML Archive on
help / color / mirror / Atom feed
From: Miquel Raynal <>
To: Boris Brezillon <>
Cc: Geert Uytterhoeven <>,, David Woodhouse <>,
	Brian Norris <>,
	Marek Vasut <>,
	Richard Weinberger <>,,
Subject: Re: [PATCH] m68k: Implement ndelay() as an inline function to force type checking/casting
Date: Mon, 14 May 2018 09:23:34 +0200	[thread overview]
Message-ID: <20180514092334.43b5ee3c@xps13> (raw)
In-Reply-To: <>

Hi Boris,

On Sun, 13 May 2018 16:02:12 +0200, Boris Brezillon
<> wrote:

> ndelay() is supposed to take an unsigned long, but if you define
> ndelay() as a macro and the caller pass an unsigned long long instead
> of an unsigned long, the unsigned long long to unsigned long cast is
> not done and we end up with an "undefined reference to `__udivdi3'"
> error at link time.
> Fix that by making ndelay() an inline function and then defining dummy
> ndelay() macro that redirects to the ndelay() function (it's how most
> archs do to implement ndelay()).
> Fixes: c8ee038bd148 ("m68k: Implement ndelay() based on the existing udelay() logic")
> Signed-off-by: Boris Brezillon <>

Thanks for fixing it.

Reviewed-by: Miquel Raynal <>

Miquel Raynal, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering

  parent reply	other threads:[~2018-05-14  7:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-13 14:02 Boris Brezillon
2018-05-13 22:38 ` Andy Shevchenko
2018-05-14  7:23 ` Miquel Raynal [this message]
2018-05-14  9:29 ` Geert Uytterhoeven
2018-05-14 10:52   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180514092334.43b5ee3c@xps13 \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] m68k: Implement ndelay() as an inline function to force type checking/casting' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).