From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752147AbeENTTE (ORCPT ); Mon, 14 May 2018 15:19:04 -0400 Received: from mail-qt0-f195.google.com ([209.85.216.195]:41970 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752118AbeENTTB (ORCPT ); Mon, 14 May 2018 15:19:01 -0400 X-Google-Smtp-Source: AB8JxZo++v7NsIARho6IhcIOplu8rmgGSdXvMT9K8wXsOWeqjEYeACYhQKv93uWvYMOz1rFUWbuf6A== Date: Mon, 14 May 2018 15:11:10 -0400 From: Kent Overstreet To: Jens Axboe Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, Ingo Molnar , Andrew Morton Subject: Re: [PATCH 01/10] mempool: Add mempool_init()/mempool_exit() Message-ID: <20180514191110.GB8869@kmo-pixel> References: <20180509013358.16399-1-kent.overstreet@gmail.com> <20180509013358.16399-2-kent.overstreet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 11, 2018 at 03:11:45PM -0600, Jens Axboe wrote: > On 5/8/18 7:33 PM, Kent Overstreet wrote: > > Allows mempools to be embedded in other structs, getting rid of a > > pointer indirection from allocation fastpaths. > > > > mempool_exit() is safe to call on an uninitialized but zeroed mempool. > > Looks fine to me. I'd like to carry it through the block branch, as some > of the following cleanups depend on it. Kent, can you post a v2 with > the destroy -> exit typo fixed up? > > But would be nice to have someone sign off on it... Done - it's now up in my git repo: http://evilpiepirate.org/git/bcachefs.git bcachefs-block