LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	robh+dt@kernel.org, mark.rutland@arm.com, afd@ti.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-leds@vger.kernel.org
Subject: Re: [PATCH v5 2/2] leds: lm3601x: Introduce the lm3601x LED driver
Date: Mon, 14 May 2018 22:16:31 +0200	[thread overview]
Message-ID: <20180514201631.GC3276@amd> (raw)
In-Reply-To: <4a631a8e-18ba-0886-039e-004980ae0cc3@ti.com>

[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]

On Mon 2018-05-14 15:13:34, Dan Murphy wrote:
> Pavel
> 
> On 05/14/2018 03:05 PM, Pavel Machek wrote:
> > Hi!
> > 
> >>> OK.
> >>
> >> OK I looked at the max776973 driver and well if the flash-max-microamp and
> >> flash-max-timeout-us nodes are missing it sets a default value for each if the
> >> node is not present.
> >>
> >> So should we remove this code from the Max77693 driver too and fail probe as being asked
> >> in this driver?
> > 
> > Well, modifying driver without access to the hardware is tricky
> > :-(. If it does something stupid (like using other than minimum values
> > for the flash-max-microamp/flash-max-timeout-us), it needs to be
> > fixed.
> 
> Well we should be able to test the probe/parse dt node and reject the probe if the node is not
> present.  That can be done without HW the setup is done pretty early in the probe without even attempting to communicate
> with the hardware.
> 

Well, yes, you can do that.

But if someone is actively using board with DT w/o flash-max-microamp,
you'll make them unhappy.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2018-05-14 20:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-10 17:47 [PATCH v5 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver Dan Murphy
2018-05-10 17:47 ` [PATCH v5 2/2] leds: lm3601x: Introduce the lm3601x LED driver Dan Murphy
2018-05-10 20:48   ` Jacek Anaszewski
2018-05-11 11:56     ` Dan Murphy
2018-05-11 20:26       ` Jacek Anaszewski
2018-05-14 19:40       ` Dan Murphy
2018-05-14 19:49         ` Andy Shevchenko
2018-05-14 20:05         ` Pavel Machek
2018-05-14 20:13           ` Dan Murphy
2018-05-14 20:16             ` Pavel Machek [this message]
2018-05-14 20:31               ` Dan Murphy
2018-05-14 20:05         ` Jacek Anaszewski
2018-05-14 20:09           ` Dan Murphy
2018-05-10 18:54 ` [PATCH v5 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver Pavel Machek
2018-05-10 19:06   ` Dan Murphy
2018-05-10 19:10     ` Dan Murphy
2018-05-10 20:17       ` Jacek Anaszewski
2018-05-11 12:12         ` Dan Murphy
2018-05-11 20:27           ` Jacek Anaszewski
2018-05-14 20:07             ` Dan Murphy
2018-05-14 20:48               ` Jacek Anaszewski
2018-05-10 20:50 ` Jacek Anaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180514201631.GC3276@amd \
    --to=pavel@ucw.cz \
    --cc=afd@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH v5 2/2] leds: lm3601x: Introduce the lm3601x LED driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).