LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Simon Horman <firstname.lastname@example.org>
To: Phil Edworthy <email@example.com>
Cc: Andy Shevchenko <firstname.lastname@example.org>,
Hoan Tran <email@example.com>,
Linus Walleij <firstname.lastname@example.org>,
Mark Rutland <email@example.com>,
Rob Herring <firstname.lastname@example.org>,
Lee Jones <email@example.com>,
Michel Pollet <firstname.lastname@example.org>,
Subject: Re: [PATCH v6] gpio: dwapb: Add support for 1 interrupt per port A GPIO
Date: Tue, 15 May 2018 09:42:42 +0200 [thread overview]
Message-ID: <email@example.com> (raw)
On Fri, May 11, 2018 at 09:31:37AM +0100, Phil Edworthy wrote:
> The DesignWare GPIO IP can be configured for either 1 interrupt or 1
> per GPIO in port A, but the driver currently only supports 1 interrupt.
> See the DesignWare DW_apb_gpio Databook description of the
> 'GPIO_INTR_IO' parameter.
> This change allows the driver to work with up to 32 interrupts, it will
> get as many interrupts as specified in the DT 'interrupts' property.
> It doesn't do anything clever with the different interrupts, it just calls
> the same handler used for single interrupt hardware.
> Signed-off-by: Phil Edworthy <firstname.lastname@example.org>
> Reviewed-by: Rob Herring <email@example.com>
> Acked-by: Lee Jones <firstname.lastname@example.org>
> One point to mention is that I have made it possible for users to have
> unconnected interrupts by specifying holes in the list of interrupts. This is
> done by supporting the interrupts-extended DT prop.
> However, I have no use for this and had to hack some test case for this.
> Perhaps the driver should support 1 interrupt or all GPIOa as interrupts?
> - Treat DT and ACPI the same as much as possible. Note that we can't use
> platform_get_irq() to get the DT interrupts as they are in the port
> sub-node and hence do not have an associated platform device.
> - Rolled ACPI companion code provided by Hoan Tran into this patch.
> - Use of_irq_get() instead of of_irq_parse_one()+irq_create_of_mapping()
> - Rolled mfd: intel_quark_i2c_gpio fix into this patch to avoid bisect problems
> - Replaced interrupt-mask DT prop with support for the interrupts-extended
> prop. This means replacing the call to irq_of_parse_and_map() with calls
> to of_irq_parse_one() and irq_create_of_mapping().
> .../devicetree/bindings/gpio/snps-dwapb-gpio.txt | 9 +++-
> drivers/gpio/gpio-dwapb.c | 49 +++++++++++++++-------
> drivers/mfd/intel_quark_i2c_gpio.c | 3 +-
> include/linux/platform_data/gpio-dwapb.h | 3 +-
> 4 files changed, 45 insertions(+), 19 deletions(-)
> diff --git a/Documentation/devicetree/bindings/gpio/snps-dwapb-gpio.txt b/Documentation/devicetree/bindings/gpio/snps-dwapb-gpio.txt
> index 4a75da7..3c1118b 100644
> --- a/Documentation/devicetree/bindings/gpio/snps-dwapb-gpio.txt
> +++ b/Documentation/devicetree/bindings/gpio/snps-dwapb-gpio.txt
> @@ -26,8 +26,13 @@ controller.
> the second encodes the triger flags encoded as described in
> - interrupt-parent : The parent interrupt controller.
> -- interrupts : The interrupt to the parent controller raised when GPIOs
> - generate the interrupts.
> +- interrupts : The interrupts to the parent controller raised when GPIOs
> + generate the interrupts. If the controller provides one combined interrupt
> + for all GPIOs, specify a single interrupt. If the controller provides one
> + interrupt for each GPIO, provide a list of interrupts that correspond to each
> + of the GPIO pins. When specifying multiple interrupts, if any are unconnected,
> + use the interrupts-extended property to specify the interrupts and set the
> + interrupt controller handle for unused interrupts to 0.
> - snps,nr-gpios : The number of pins in the port, a single cell.
> - resets : Reset line for the controller.
An enhanced example might be helpful.
That not withstanding:
Reviewed-by: Simon Horman <email@example.com>
next prev parent reply other threads:[~2018-05-15 7:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 8:31 Phil Edworthy
2018-05-15 7:42 ` Simon Horman [this message]
2018-05-16 21:40 ` Hoan Tran
2018-05-17 6:25 ` Lee Jones
2018-05-17 16:46 ` Hoan Tran
2018-05-23 8:29 ` Linus Walleij
2018-05-23 8:45 ` Phil Edworthy
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: [PATCH v6] gpio: dwapb: Add support for 1 interrupt per port A GPIO' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).