LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Peng Fan <peng.fan@nxp.com>
To: rafael.j.wysocki@intel.com
Cc: ulf.hansson@linaro.org, fabio.estevam@nxp.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-imx@nxp.com,
Peng Fan <peng.fan@nxp.com>
Subject: [RFC] platform: detach from PM domains on shutdown
Date: Tue, 15 May 2018 17:01:10 +0800 [thread overview]
Message-ID: <20180515090110.26820-1-peng.fan@nxp.com> (raw)
When reboot Linux, the PM domains attached to a device
are not shutdown. To SoCs which relys on reset the whole SoC,
there is no need to shutdown PM domains, but to Linux running
in a virtual machine with devices pass-through, we could not
reset the whole SoC. Currently we need Linux to shutdown its
PM domains when reboot.
commit 2d30bb0b3889 ("platform: Do not detach from PM domains on shutdown"),
removes what this patch tries to add, because of a warning.
commit e79aee49bcf9 ("PM: Avoid false-positive warnings in dev_pm_domain_set()")
already fixes the false alarm warning. So let's detach the power domain
to shutdown PM domains after driver shutdown.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
I do not find a better place to shutdown power domain when reboot Linux,
so add back the line that commit 2d30bb0b3889 removes, because it is
a false alarm warning as commit e79aee49bcf9 describes.
drivers/base/platform.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index 8075ddc70a17..a5929f24dc3c 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -616,6 +616,7 @@ static void platform_drv_shutdown(struct device *_dev)
if (drv->shutdown)
drv->shutdown(dev);
+ dev_pm_domain_detach(_dev, true);
}
/**
--
2.14.1
next reply other threads:[~2018-05-15 8:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 9:01 Peng Fan [this message]
2018-05-16 9:52 ` Ulf Hansson
2018-05-16 12:53 ` Peng Fan
2018-05-16 21:34 ` Rafael J. Wysocki
2018-05-17 2:33 ` Peng Fan
2018-05-17 8:01 ` Rafael J. Wysocki
2018-05-17 12:37 ` Peng Fan
2018-05-18 7:54 ` Rafael J. Wysocki
2018-05-18 8:53 ` Peng Fan
2018-05-28 8:01 ` Peng Fan
2018-05-28 8:31 ` Rafael J. Wysocki
2018-05-29 7:52 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180515090110.26820-1-peng.fan@nxp.com \
--to=peng.fan@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=ulf.hansson@linaro.org \
--subject='Re: [RFC] platform: detach from PM domains on shutdown' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).