LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] staging: speakup: use true/false instead of 1/0
@ 2018-05-14 20:57 Samuel Thibault
  2018-05-15 12:00 ` Dan Carpenter
  0 siblings, 1 reply; 2+ messages in thread
From: Samuel Thibault @ 2018-05-14 20:57 UTC (permalink / raw)
  To: Greg KH; +Cc: devel, kirk, speakup, linux-kernel, chris

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
 drivers/staging/speakup/buffers.c |    2 +-
 drivers/staging/speakup/main.c    |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/staging/speakup/buffers.c
+++ b/drivers/staging/speakup/buffers.c
@@ -80,7 +80,7 @@ void synth_buffer_add(u16 ch)
 	/* We have written something to the speech synthesis, so we are not
 	 * paused any more.
 	 */
-	spk_paused = 0;
+	spk_paused = false;
 }
 
 u16 synth_buffer_getc(void)
--- a/drivers/staging/speakup/main.c
+++ b/drivers/staging/speakup/main.c
@@ -1784,7 +1784,7 @@ static void speakup_con_update(struct vc
 	speakup_date(vc);
 	if (vc->vc_mode == KD_GRAPHICS && !spk_paused && spk_str_pause[0]) {
 		synth_printf("%s", spk_str_pause);
-		spk_paused = 1;
+		spk_paused = true;
 	}
 	spin_unlock_irqrestore(&speakup_info.spinlock, flags);
 }
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: speakup: use true/false instead of 1/0
  2018-05-14 20:57 [PATCH] staging: speakup: use true/false instead of 1/0 Samuel Thibault
@ 2018-05-15 12:00 ` Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2018-05-15 12:00 UTC (permalink / raw)
  To: Samuel Thibault, Greg KH, w.d.hubbs, chris, kirk, devel,
	linux-kernel, speakup

On Mon, May 14, 2018 at 10:57:25PM +0200, Samuel Thibault wrote:
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Greg doesn't accept patches without a commit message.  Just say which
tool warned for example.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-05-15 12:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-14 20:57 [PATCH] staging: speakup: use true/false instead of 1/0 Samuel Thibault
2018-05-15 12:00 ` Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).