LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 0/1] thunderbolt: Fix for v4.17-rc6
@ 2018-05-15 13:04 Mika Westerberg
2018-05-15 13:04 ` [PATCH 1/1] thunderbolt: Handle NULL boot ACL entries properly Mika Westerberg
0 siblings, 1 reply; 2+ messages in thread
From: Mika Westerberg @ 2018-05-15 13:04 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Andreas Noever, Michael Jamet, Yehezkel Bernat, Mika Westerberg,
linux-kernel
Hi Greg,
There is one fix to make preboot ACL handling show NULL entries correctly
in sysfs.
The patch is also included in case you want to apply it directly instead of
pulling the signed tag.
The following changes since commit 75bc37fefc4471e718ba8e651aa74673d4e0a9eb:
Linux 4.17-rc4 (2018-05-06 16:57:38 -1000)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt.git tags/thunderbolt-fixes-for-v4.17-rc6
for you to fetch changes up to 50739cafb9401b9bf7642a5e1de88987b9d0c0fa:
thunderbolt: Handle NULL boot ACL entries properly (2018-05-07 15:14:16 +0300)
Mika Westerberg (1):
thunderbolt: Handle NULL boot ACL entries properly
drivers/thunderbolt/icm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.17.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 1/1] thunderbolt: Handle NULL boot ACL entries properly
2018-05-15 13:04 [PATCH 0/1] thunderbolt: Fix for v4.17-rc6 Mika Westerberg
@ 2018-05-15 13:04 ` Mika Westerberg
0 siblings, 0 replies; 2+ messages in thread
From: Mika Westerberg @ 2018-05-15 13:04 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Andreas Noever, Michael Jamet, Yehezkel Bernat, Mika Westerberg,
linux-kernel
If the boot ACL entry is already NULL we should not fill in the upper
two DWs with 0xfffffffff. Otherwise they are not shown as empty entries
when the sysfs attribute is read.
Fixes: 9aaa3b8b4c56 ("thunderbolt: Add support for preboot ACL")
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Yehezkel Bernat <yehezkelshb@gmail.com>
---
drivers/thunderbolt/icm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thunderbolt/icm.c b/drivers/thunderbolt/icm.c
index 2d2ceda9aa26..500911f16498 100644
--- a/drivers/thunderbolt/icm.c
+++ b/drivers/thunderbolt/icm.c
@@ -1255,7 +1255,7 @@ static int icm_ar_get_boot_acl(struct tb *tb, uuid_t *uuids, size_t nuuids)
/* Map empty entries to null UUID */
uuid[0] = 0;
uuid[1] = 0;
- } else {
+ } else if (uuid[0] != 0 || uuid[1] != 0) {
/* Upper two DWs are always one's */
uuid[2] = 0xffffffff;
uuid[3] = 0xffffffff;
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-15 13:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-15 13:04 [PATCH 0/1] thunderbolt: Fix for v4.17-rc6 Mika Westerberg
2018-05-15 13:04 ` [PATCH 1/1] thunderbolt: Handle NULL boot ACL entries properly Mika Westerberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).