LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Faiz Abbas <faiz_abbas@ti.com>
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	devicetree@vger.kernel.org, bcousson@baylibre.com,
	robh+dt@kernel.org, mark.rutland@arm.com, paul@pwsan.com,
	lokeshvutla@ti.com, linux@armlinux.org.uk
Subject: Re: [PATCH 1/3] ARM: dra762: hwmod: Add MCAN support
Date: Tue, 15 May 2018 10:14:59 -0700	[thread overview]
Message-ID: <20180515171459.GP98604@atomide.com> (raw)
In-Reply-To: <b4d95a08-82fd-9f39-53e7-977351788c88@ti.com>

* Faiz Abbas <faiz_abbas@ti.com> [180515 06:05]:
> Hi Tony,
> 
> On Tuesday 01 May 2018 08:56 PM, Tony Lindgren wrote:
> > Hi,
> > 
> > * Faiz Abbas <faiz_abbas@ti.com> [180408 09:59]:
> >> From: Lokesh Vutla <lokeshvutla@ti.com>
> >>
> >> Add MCAN hwmod data and register it for dra762 silicons.
> >>
> >> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> >> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> >> ---
> >>  arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 32 +++++++++++++++++++++++++++++++
> >>  1 file changed, 32 insertions(+)
> >>
> >> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> >> index 62352d1..a2cd7f8 100644
> >> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> >> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> >> @@ -1356,6 +1356,29 @@ static struct omap_hwmod dra7xx_mailbox13_hwmod = {
> >>  };
> >>  
> >>  /*
> >> + * 'mcan' class
> >> + *
> >> + */
> >> +static struct omap_hwmod_class dra76x_mcan_hwmod_class = {
> >> +	.name	= "mcan",
> >> +};
> > 
> > Looks like you're missing the related struct omap_hwmod_class_sysconfig
> > entry for this with the rev and sysconfig registers.
> > 
> 
> Sorry, I missed this email earlier. The MCAN module doesn't have
> sysconfig registers.

If there's no sysconfig register you should have no need for adding
anything to omap_hwmod_7xx_data.c. We now have the dts clkctrl
clocks, you can just add that to the dts node for the device.

Regards,

Tony

  reply	other threads:[~2018-05-15 17:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-08  9:58 [PATCH 0/3] Add MCAN Support for dra76x Faiz Abbas
2018-04-08  9:59 ` [PATCH 1/3] ARM: dra762: hwmod: Add MCAN support Faiz Abbas
2018-05-01 15:26   ` Tony Lindgren
2018-05-15  6:04     ` Faiz Abbas
2018-05-15 17:14       ` Tony Lindgren [this message]
2018-05-15 17:18         ` Tony Lindgren
2018-05-15 17:23           ` Tony Lindgren
2018-05-17  8:13             ` Faiz Abbas
2018-05-17 21:04               ` Tony Lindgren
2018-05-17 21:09   ` Tony Lindgren
2018-05-18 11:54     ` Faiz Abbas
2018-04-08  9:59 ` [PATCH 2/3] ARM: dts: dra762: Add MCAN clock support Faiz Abbas
2018-05-15 17:16   ` Tony Lindgren
2018-04-08  9:59 ` [PATCH 3/3] ARM: dts: dra76x: Add MCAN node Faiz Abbas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180515171459.GP98604@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=faiz_abbas@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=lokeshvutla@ti.com \
    --cc=mark.rutland@arm.com \
    --cc=paul@pwsan.com \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH 1/3] ARM: dra762: hwmod: Add MCAN support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).