LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Keerthy <j-keerthy@ti.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
	bcousson@baylibre.com, linux-omap@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] ARM: dts: am437x boards: Correct (again) tps65218 irq type
Date: Tue, 15 May 2018 11:15:43 -0700	[thread overview]
Message-ID: <20180515181543.GW98604@atomide.com> (raw)
In-Reply-To: <4b4100d0-85e1-659b-8f7e-b3d4b3925e82@ti.com>

* Keerthy <j-keerthy@ti.com> [180509 04:03]:
> 
> 
> On Tuesday 08 May 2018 07:46 PM, Tony Lindgren wrote:
> > * Peter Ujfalusi <peter.ujfalusi@ti.com> [180508 13:22]:
> >> Hi,
> >>
> >> While based on the datasheet of tps65218 the INT is low active, the GIC_SPI
> >> does not support anythin but IRQ_TYPE_LEVEL_HIGH or IRQ_TYPE_EDGE_RISING:
> >>
> >> [    2.761814] genirq: Setting trigger mode 8 for irq 102 failed (irq_chip_set_type_parent+0x0/0x30)
> >> [    2.770913] tps65218 0-0024: Failed to request IRQ 102 for tps65218: -22
> >> [    2.777854] tps65218: probe of 0-0024 failed with error -22
> > 
> > So does the tps65218 have some register to control the interrupt
> > direction or is it's datasheet wrong?
> > 
> > BTW, ADC might be a good test case for PMIC interrupt if it has one.
> 
> There is no ADC on this PMIC.
> 
> > 
> >> Use LEVEL_HIGH for the interrupt as it looks to be the correct setting:
> >> INTn of tps65218 is connected to NMIn of the SoC.
> >>
> >> The offending patches are only in linux-next.
> > 
> > OK

Applying these all into omap-for-v4.18/dt.

Regards,

Tony

      reply	other threads:[~2018-05-15 18:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-08 13:20 Peter Ujfalusi
2018-05-08 13:20 ` [PATCH 1/4] ARM: dts: am437x-gp-evm: Fixup " Peter Ujfalusi
2018-05-08 13:20 ` [PATCH 2/4] ARM: dts: am437x-cm-t43: " Peter Ujfalusi
2018-05-08 13:20 ` [PATCH 3/4] ARM: dts: am437x-epos-evm: " Peter Ujfalusi
2018-05-08 13:20 ` [PATCH 4/4] Revert "ARM: dts: am437x-sk-evm: Correct tps65218 irq type" Peter Ujfalusi
2018-05-08 14:16 ` [PATCH 0/4] ARM: dts: am437x boards: Correct (again) tps65218 irq type Tony Lindgren
2018-05-09  4:00   ` Keerthy
2018-05-15 18:15     ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180515181543.GW98604@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=j-keerthy@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    --subject='Re: [PATCH 0/4] ARM: dts: am437x boards: Correct (again) tps65218 irq type' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).