LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Petr Mladek <pmladek@suse.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>,
	linux-serial@vger.kernel.org,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Arnd Bergmann <arnd@arndb.de>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 3/3] serial: 8250_port: Disable DMA operations for kernel console
Date: Tue, 15 May 2018 21:34:09 +0300	[thread overview]
Message-ID: <20180515183409.78046-4-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20180515183409.78046-1-andriy.shevchenko@linux.intel.com>

It will be too tricky and error prone to allow DMA operations on kernel
console.

Disable any kind of DMA operations in such case.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/tty/serial/8250/8250_port.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
index db97222a1bf4..9a4696ea728b 100644
--- a/drivers/tty/serial/8250/8250_port.c
+++ b/drivers/tty/serial/8250/8250_port.c
@@ -2371,7 +2371,10 @@ int serial8250_do_startup(struct uart_port *port)
 	 * Request DMA channels for both RX and TX.
 	 */
 	if (up->dma) {
-		retval = serial8250_request_dma(up);
+		if (uart_console(port))
+			retval = -ENXIO;
+		else
+			retval = serial8250_request_dma(up);
 		if (retval)
 			pr_warn_ratelimited("ttyS%d - failed to request DMA\n",
 					    serial_index(port));
-- 
2.17.0

  parent reply	other threads:[~2018-05-15 18:34 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-15 18:34 [PATCH v1 0/3] console, serial8250: Disable PM and DMA ops Andy Shevchenko
2018-05-15 18:34 ` [PATCH v1 1/3] console: introduce ->exit() callback Andy Shevchenko
2018-05-15 18:34 ` [PATCH v1 2/3] serial: 8250_port: Don't use power management for kernel console Andy Shevchenko
2018-05-15 18:34 ` Andy Shevchenko [this message]
2018-05-16 10:55   ` [PATCH v1 3/3] serial: 8250_port: Disable DMA operations " Sebastian Andrzej Siewior
2018-05-16 12:58     ` Andy Shevchenko
2018-05-16 18:20       ` Sebastian Andrzej Siewior
2018-05-15 18:37 ` [PATCH v1 0/3] console, serial8250: Disable PM and DMA ops Andy Shevchenko
2018-05-16 10:08   ` Sebastian Andrzej Siewior
2018-05-16 10:17     ` Andy Shevchenko
2018-05-16 10:47       ` Sebastian Andrzej Siewior
2018-05-16 13:10         ` Andy Shevchenko
2018-05-17 13:56           ` Tony Lindgren
2018-05-17 16:38             ` Andy Shevchenko
2018-05-17 19:30               ` Tony Lindgren
2018-05-22 21:39                 ` Andy Shevchenko
2018-05-23 17:58                   ` Tony Lindgren
2018-05-23 18:32                     ` Tony Lindgren
2018-07-18 15:14                     ` Andy Shevchenko
2018-07-19  6:47                       ` Tony Lindgren
2018-05-17 17:04             ` Tony Lindgren
2018-05-17 13:48         ` Tony Lindgren
2018-05-17 16:36           ` Andy Shevchenko
2018-05-17 19:48             ` Tony Lindgren
2018-05-22 21:52               ` Andy Shevchenko
2018-05-23 18:00                 ` Tony Lindgren
2018-07-18 14:50                   ` Andy Shevchenko
2018-07-19  6:50                     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180515183409.78046-4-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=bigeasy@linutronix.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    --subject='Re: [PATCH v1 3/3] serial: 8250_port: Disable DMA operations for kernel console' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).