From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751210AbeEPSrL (ORCPT ); Wed, 16 May 2018 14:47:11 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:43892 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750786AbeEPSrK (ORCPT ); Wed, 16 May 2018 14:47:10 -0400 Date: Wed, 16 May 2018 14:47:08 -0400 (EDT) Message-Id: <20180516.144708.917881173820651215.davem@davemloft.net> To: yuehaibing@huawei.com Cc: tklauser@distanz.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: ethoc: Remove useless test before clk_disable_unprepare From: David Miller In-Reply-To: <20180516111822.26440-1-yuehaibing@huawei.com> References: <20180516111822.26440-1-yuehaibing@huawei.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing Date: Wed, 16 May 2018 19:18:22 +0800 > clk_disable_unprepare() already checks that the clock pointer is valid. > No need to test it before calling it. > > Signed-off-by: YueHaibing Applied.