LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
	Michal Marek <michal.lkml@markovi.net>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andreas Faerber <afaerber@suse.com>
Subject: Re: [PATCH] Makefile: disable PIE before testing asm goto
Date: Wed, 16 May 2018 10:16:35 +0200	[thread overview]
Message-ID: <20180516081635.GE12198@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180516055136.6F4EAA095A@unicorn.suse.cz>

On Wed, May 16, 2018 at 07:51:36AM +0200, Michal Kubecek wrote:
> Since commit e501ce957a78 ("x86: Force asm-goto"), aarch64 build on
> distributions which enable PIE by default (e.g. openSUSE Tumbleweed) does
> not detect support for asm goto correctly. The problem is that ARM specific
> part of scripts/gcc-goto.sh fails with PIE even with recent gcc versions.
> Moving the asm goto detection up in Makefile put it before the place where
> we disable PIE. As a result, kernel is built without jump label support.

Ugh, that's nasty. Thanks for fixing that.

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>

  reply	other threads:[~2018-05-16  8:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-16  5:51 Michal Kubecek
2018-05-16  8:16 ` Peter Zijlstra [this message]
2018-05-17 13:34 ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180516081635.GE12198@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=afaerber@suse.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=mkubecek@suse.cz \
    --cc=yamada.masahiro@socionext.com \
    --subject='Re: [PATCH] Makefile: disable PIE before testing asm goto' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).