LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <firstname.lastname@example.org> To: Andy Shevchenko <email@example.com> Cc: Andy Shevchenko <firstname.lastname@example.org>, Petr Mladek <email@example.com>, Sergey Senozhatsky <firstname.lastname@example.org>, Steven Rostedt <email@example.com>, Linux Kernel Mailing List <firstname.lastname@example.org>, Greg Kroah-Hartman <email@example.com>, Jiri Slaby <firstname.lastname@example.org>, "open list:SERIAL DRIVERS" <email@example.com>, Arnd Bergmann <firstname.lastname@example.org>, Tony Lindgren <email@example.com> Subject: Re: [PATCH v1 0/3] console, serial8250: Disable PM and DMA ops Date: Wed, 16 May 2018 12:47:35 +0200 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <CAHp75Vc2bJQHiWYcdKK+7wwMw2fSWxMauxP-dMRUAUdKnet7WQ@mail.gmail.com> On 2018-05-16 13:17:36 [+0300], Andy Shevchenko wrote: > > The output is usually short so there > > shouldn't be much benefit from using it. > > > I remember Tony wanted runtime-pm on the kernel console, too. And he > > told me explicit how to test it so that it works. Once the UART goes > > into PM (down), the whole IP block can go into power save mode. The > > board can be woken up by sending a character via the UART. The first few > > (incoming / read) characters are lost until the IP block is up again the > > frequency stable. This is known / expected. > > Don't consider world the OMAP only. The things more complicated if we > go out of it. Which I tried to explain in the commit message of patch > 2. I am not saying the world is OMAP only. I just tried to explain how any why it got there and its purpose. I haven't NACKed it. I would believe that with that information and Tony not defending his use case or possible change it somehow so it is not standing in your way, Greg would have enough information to go your way. But since I am on it. You have to enable runtime-PM for the UART. So what is the problem if you simply don't enable it for the UART which used as the kernel console? >From reading the description of #2, my understanding is that you are afraid that enabling the UART (bringing it from power-down mode) might take too long because it requires (or might require) an ACPI function call. This brings me again to: why bother and enable it in the first place? Because this might not work from NMI context. >From looking at #2. You remove put/get in console_write() and avoid runtime PM by pm_runtime_get_noresume() and need the extra hook on console exit. I wasn't aware that you can remove the console at runtime (and assumed you have to stick to what said in console= at bootime). Because if that is the case, you could simply strip UART_CAP_RPM and then there is no more runtime-PM for you. Or is it too simple and I miss something here? > > In order to achieve the same thing you would have to disable the kernel > > console on that UART. I leave this to Tony. > > Precisely the point of the series. Sebastian
next prev parent reply other threads:[~2018-05-16 10:47 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-15 18:34 [PATCH v1 0/3] console, serial8250: Disable PM and DMA ops Andy Shevchenko 2018-05-15 18:34 ` [PATCH v1 1/3] console: introduce ->exit() callback Andy Shevchenko 2018-05-15 18:34 ` [PATCH v1 2/3] serial: 8250_port: Don't use power management for kernel console Andy Shevchenko 2018-05-15 18:34 ` [PATCH v1 3/3] serial: 8250_port: Disable DMA operations " Andy Shevchenko 2018-05-16 10:55 ` Sebastian Andrzej Siewior 2018-05-16 12:58 ` Andy Shevchenko 2018-05-16 18:20 ` Sebastian Andrzej Siewior 2018-05-15 18:37 ` [PATCH v1 0/3] console, serial8250: Disable PM and DMA ops Andy Shevchenko 2018-05-16 10:08 ` Sebastian Andrzej Siewior 2018-05-16 10:17 ` Andy Shevchenko 2018-05-16 10:47 ` Sebastian Andrzej Siewior [this message] 2018-05-16 13:10 ` Andy Shevchenko 2018-05-17 13:56 ` Tony Lindgren 2018-05-17 16:38 ` Andy Shevchenko 2018-05-17 19:30 ` Tony Lindgren 2018-05-22 21:39 ` Andy Shevchenko 2018-05-23 17:58 ` Tony Lindgren 2018-05-23 18:32 ` Tony Lindgren 2018-07-18 15:14 ` Andy Shevchenko 2018-07-19 6:47 ` Tony Lindgren 2018-05-17 17:04 ` Tony Lindgren 2018-05-17 13:48 ` Tony Lindgren 2018-05-17 16:36 ` Andy Shevchenko 2018-05-17 19:48 ` Tony Lindgren 2018-05-22 21:52 ` Andy Shevchenko 2018-05-23 18:00 ` Tony Lindgren 2018-07-18 14:50 ` Andy Shevchenko 2018-07-19 6:50 ` Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).