LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: [PATCH 7/7] slimbus: messaging: initialize completion correctly
Date: Wed, 16 May 2018 12:36:42 +0100	[thread overview]
Message-ID: <20180516113642.28136-8-srinivas.kandagatla@linaro.org> (raw)
In-Reply-To: <20180516113642.28136-1-srinivas.kandagatla@linaro.org>

slim_val_inf can contain random value from stack, make sure the completion
is initialized to NULL while filling the msg.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 drivers/slimbus/messaging.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c
index fd0788019357..2635eaaadf4a 100644
--- a/drivers/slimbus/messaging.c
+++ b/drivers/slimbus/messaging.c
@@ -277,6 +277,7 @@ static void slim_fill_msg(struct slim_val_inf *msg, u32 addr,
 	msg->num_bytes = count;
 	msg->rbuf = rbuf;
 	msg->wbuf = wbuf;
+	msg->comp = NULL;
 }
 
 /**
-- 
2.16.2

      parent reply	other threads:[~2018-05-16 11:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-16 11:36 [PATCH 0/7] slimbus: fixes and some helpers Srinivas Kandagatla
2018-05-16 11:36 ` [PATCH 1/7] slimbus: core: add of_slim_device_get() helper Srinivas Kandagatla
2018-05-16 11:36 ` [PATCH 2/7] slimbus: core: rearrange slim_eaddr structure Srinivas Kandagatla
2018-05-16 11:36 ` [PATCH 3/7] slimbus: core: add need_tid flag to slim_msg_txn Srinivas Kandagatla
2018-05-17  0:38   ` [alsa-devel] " kbuild test robot
2018-05-16 11:36 ` [PATCH 4/7] slimbus: messaging: pass correct wbuf Srinivas Kandagatla
2018-05-16 11:36 ` [PATCH 5/7] slimbus: messaging: remove multiple calls to pm_runtime_mark_last_busy Srinivas Kandagatla
2018-05-16 11:36 ` [PATCH 6/7] slimbus: messaging: add slim_prepare_txn() helper function Srinivas Kandagatla
2018-05-16 11:36 ` Srinivas Kandagatla [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180516113642.28136-8-srinivas.kandagatla@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 7/7] slimbus: messaging: initialize completion correctly' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).