LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Petr Mladek <pmladek@suse.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>,
	linux-serial@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v1 3/3] serial: 8250_port: Disable DMA operations for kernel console
Date: Wed, 16 May 2018 20:20:37 +0200	[thread overview]
Message-ID: <20180516182037.uvjqe2gyqtf3r24b@linutronix.de> (raw)
In-Reply-To: <171c11a999e2d9580d3783588d20b58e753c89ef.camel@linux.intel.com>

On 2018-05-16 15:58:10 [+0300], Andy Shevchenko wrote:
> > > It will be too tricky and error prone to allow DMA operations on
> > > kernel
> > > console.
> > 
> > Why is it tricky and error prone? I had it working…
> 
> On OMAP only? Had you tested this on let's say Intel Cherrytrail where
> DMA controller is a separate PCI device which needs to be handled
> separately from UART IP.

My point was simply to clarify if this entirely broken and requires
backports or if this makes things more complicated and could be avoided.

> > But I don't mind dropping the DMA on the kernel console because I
> > doubt
> > that we lose something here by disabling it. I would even imagine that
> > it gets "simpler" (maybe what you tried to say by "error prone") to
> > print something in the NMI case by writing directly to the FIFO
> > register
> > instead setting up a DMA transfer and so on.
> 
> "error prone" mostly refers to patch 2 commit message. Here it seems I
> need to put something like above to explain why DMA case tricky _as
> well_.

Yes, full context is helpful :)

Sebastian

  reply	other threads:[~2018-05-16 18:20 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-15 18:34 [PATCH v1 0/3] console, serial8250: Disable PM and DMA ops Andy Shevchenko
2018-05-15 18:34 ` [PATCH v1 1/3] console: introduce ->exit() callback Andy Shevchenko
2018-05-15 18:34 ` [PATCH v1 2/3] serial: 8250_port: Don't use power management for kernel console Andy Shevchenko
2018-05-15 18:34 ` [PATCH v1 3/3] serial: 8250_port: Disable DMA operations " Andy Shevchenko
2018-05-16 10:55   ` Sebastian Andrzej Siewior
2018-05-16 12:58     ` Andy Shevchenko
2018-05-16 18:20       ` Sebastian Andrzej Siewior [this message]
2018-05-15 18:37 ` [PATCH v1 0/3] console, serial8250: Disable PM and DMA ops Andy Shevchenko
2018-05-16 10:08   ` Sebastian Andrzej Siewior
2018-05-16 10:17     ` Andy Shevchenko
2018-05-16 10:47       ` Sebastian Andrzej Siewior
2018-05-16 13:10         ` Andy Shevchenko
2018-05-17 13:56           ` Tony Lindgren
2018-05-17 16:38             ` Andy Shevchenko
2018-05-17 19:30               ` Tony Lindgren
2018-05-22 21:39                 ` Andy Shevchenko
2018-05-23 17:58                   ` Tony Lindgren
2018-05-23 18:32                     ` Tony Lindgren
2018-07-18 15:14                     ` Andy Shevchenko
2018-07-19  6:47                       ` Tony Lindgren
2018-05-17 17:04             ` Tony Lindgren
2018-05-17 13:48         ` Tony Lindgren
2018-05-17 16:36           ` Andy Shevchenko
2018-05-17 19:48             ` Tony Lindgren
2018-05-22 21:52               ` Andy Shevchenko
2018-05-23 18:00                 ` Tony Lindgren
2018-07-18 14:50                   ` Andy Shevchenko
2018-07-19  6:50                     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180516182037.uvjqe2gyqtf3r24b@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    --subject='Re: [PATCH v1 3/3] serial: 8250_port: Disable DMA operations for kernel console' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).