LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Lee Jones <email@example.com>
To: Amelie DELAUNAY <firstname.lastname@example.org>
Cc: Linus Walleij <email@example.com>,
Rob Herring <firstname.lastname@example.org>,
Mark Rutland <email@example.com>,
Russell King <firstname.lastname@example.org>,
Alexandre TORGUE <email@example.com>,
Maxime Coquelin <firstname.lastname@example.org>,
"open list:GPIO SUBSYSTEM" <email@example.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
Linux ARM <firstname.lastname@example.org>
Subject: Re: [PATCH 1/5] dt-bindings: pinctrl: document the STMFX pinctrl bindings
Date: Thu, 17 May 2018 07:36:40 +0100 [thread overview]
Message-ID: <20180517063640.GK5130@dell> (raw)
On Wed, 16 May 2018, Amelie DELAUNAY wrote:
> On 05/16/2018 04:20 PM, Linus Walleij wrote:
> > On Wed, May 9, 2018 at 9:56 AM, Amelie DELAUNAY <email@example.com> wrote:
> >> Indeed, stmfx has other functions than GPIO. But, after comments done
> >> here:  and there: , it has been decided to move MFD parent/GPIO
> >> child drivers into a single PINCTRL/GPIO driver because of the following
> >> reasons:
> >> - Other stmfx functions (IDD measurement and TouchScreen controller) are
> >> not used on any of the boards using an stmfx and supported by Linux, so
> >> no way to test these functions, and no need to maintain them while they
> >> are not being used.
> >> - But, in the case a new board will use more than GPIO function on
> >> stmfx, the actual implementation allow to easily extract common init
> >> part of stmfx and put it in an MFD driver.
> >> So I could remove gpio sub-node and put its contents in stmfx node and
> >> keep single PINCTRL/GPIO driver for the time being.
> >> Please advise,
> > I would normally advice to use the right modeling from the start, create
> > the MFD driver and spawn the devices from there. It is confusing
> > if the layout of the driver(s) doesn't really match the layout of the
> > hardware.
> > I understand that it is a pain to write new MFD drivers to get your
> > things going and it would be "nice to get this working really quick
> > now" but in my experience it is better to do it right from the start.
> Hi Linus,
> Thanks for your advice. I understand the point.
> So, the right modeling would be to:
> - create an MFD driver with the common init part of stmfx
> - remove all common init part of stmfx-pinctrl driver and keep only all
> gpio/pinctrl functions.
> I will not develop the other stmfx functions (IDD measurement driver and
> TouchScreen controller driver) because, as explained ealier, they are
> not used on any of the boards using an stmfx and supported by Linux, so
> no way to test these functions, and no need to maintain them while they
> are not being used.
> Lee, are you OK with that ?
I missed a lot of this conversation I think, but from what I've read,
it sounds fine.
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-05-17 6:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 9:47 [PATCH 0/5] Introduce STMFX I2C GPIO expander Amelie Delaunay
2018-04-11 9:47 ` [PATCH 1/5] dt-bindings: pinctrl: document the STMFX pinctrl bindings Amelie Delaunay
2018-04-16 18:19 ` Rob Herring
2018-04-26 12:49 ` Linus Walleij
2018-05-09 7:56 ` Amelie DELAUNAY
2018-05-16 14:20 ` Linus Walleij
2018-05-16 15:01 ` Amelie DELAUNAY
2018-05-17 6:36 ` Lee Jones [this message]
2018-05-18 7:29 ` Amelie DELAUNAY
2018-05-18 13:52 ` Lee Jones
2018-05-18 15:13 ` Amelie DELAUNAY
2018-05-24 7:13 ` Linus Walleij
2018-05-28 11:39 ` Amelie DELAUNAY
2018-05-29 7:36 ` Lee Jones
2018-05-09 7:31 ` Amelie DELAUNAY
2018-04-11 9:47 ` [PATCH 2/5] pinctrl: Add STMFX GPIO expander Pinctrl/GPIO driver Amelie Delaunay
2018-04-12 3:11 ` kbuild test robot
2018-04-26 12:48 ` Linus Walleij
2018-05-09 9:13 ` Amelie DELAUNAY
2018-04-11 9:47 ` [PATCH 3/5] ARM: dts: stm32: add STMFX pinctrl/gpio expander support on stm32746g-eval Amelie Delaunay
2018-04-11 9:47 ` [PATCH 4/5] ARM: dts: stm32: add orange and blue leds " Amelie Delaunay
2018-04-11 9:47 ` [PATCH 5/5] ARM: dts: stm32: add joystick support " Amelie Delaunay
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: [PATCH 1/5] dt-bindings: pinctrl: document the STMFX pinctrl bindings' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).