LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* linux-next: Signed-off-by missing for commit in the hid tree
@ 2018-05-15 21:17 Stephen Rothwell
  2018-05-16 14:21 ` Rodrigo Rivas Costa
  0 siblings, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2018-05-15 21:17 UTC (permalink / raw)
  To: Jiri Kosina
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Rodrigo Rivas Costa

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

Hi Jiri,

Commit

  f82719790751 ("HID: steam: add battery device.")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the hid tree
  2018-05-15 21:17 linux-next: Signed-off-by missing for commit in the hid tree Stephen Rothwell
@ 2018-05-16 14:21 ` Rodrigo Rivas Costa
  2018-05-17  0:46   ` Stephen Rothwell
  0 siblings, 1 reply; 9+ messages in thread
From: Rodrigo Rivas Costa @ 2018-05-16 14:21 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Jiri Kosina, Linux-Next Mailing List, Linux Kernel Mailing List

On Wed, May 16, 2018 at 07:17:40AM +1000, Stephen Rothwell wrote:
> Hi Jiri,
> 
> Commit
> 
>   f82719790751 ("HID: steam: add battery device.")
> 
> is missing a Signed-off-by from its author.
Hi, Stephen, Jiri
I'm the author of this commit. Sorry for that, but I'm unsure about what
is to be done now. Should I resubmit the patch? Or can it be amended any
other way? Or it is not a big deal anyway?

Best regards.
--
Rodrigo Rivas Costa

> 
> -- 
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the hid tree
  2018-05-16 14:21 ` Rodrigo Rivas Costa
@ 2018-05-17  0:46   ` Stephen Rothwell
  0 siblings, 0 replies; 9+ messages in thread
From: Stephen Rothwell @ 2018-05-17  0:46 UTC (permalink / raw)
  To: Rodrigo Rivas Costa
  Cc: Jiri Kosina, Linux-Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

Hi Rodrigo,

On Wed, 16 May 2018 16:21:31 +0200 Rodrigo Rivas Costa <rodrigorivascosta@gmail.com> wrote:
>
> I'm the author of this commit. Sorry for that, but I'm unsure about what
> is to be done now. Should I resubmit the patch? Or can it be amended any
> other way? Or it is not a big deal anyway?

Its up to Jiri (the tree owner).  Some rebase the tree to add the SOB,
some prefer to just use it as a learning experience :-)
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* linux-next: Signed-off-by missing for commit in the hid tree
@ 2022-07-25 11:43 Stephen Rothwell
  0 siblings, 0 replies; 9+ messages in thread
From: Stephen Rothwell @ 2022-07-25 11:43 UTC (permalink / raw)
  To: Jiri Kosina, Benjamin Tissoires
  Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

Hi all,

Commit

  7af32d156ad7 ("Revert "HID: nintendo: Fix unused-const-variable compiler warning"")

is missing a Signed-off-by from its author and committer.

Reverts are commits as well.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* linux-next: Signed-off-by missing for commit in the hid tree
@ 2021-08-21  0:46 Stephen Rothwell
  0 siblings, 0 replies; 9+ messages in thread
From: Stephen Rothwell @ 2021-08-21  0:46 UTC (permalink / raw)
  To: Jiri Kosina, Benjamin Tissoires
  Cc: Luke D. Jones, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

Hi all,

Commit

  87c7ee7ad85a ("HID: asus: Prevent Claymore sending suspend event")

is missing a Signed-off-by from its author.

Actually it is just spelled wrong.  Also, please keep all the commit
message tags together at the end of the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the hid tree
  2020-06-24  7:52 Stephen Rothwell
@ 2020-06-24  7:56 ` Jiri Kosina
  0 siblings, 0 replies; 9+ messages in thread
From: Jiri Kosina @ 2020-06-24  7:56 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Benjamin Tissoires, Linux Next Mailing List, Linux Kernel Mailing List

On Wed, 24 Jun 2020, Stephen Rothwell wrote:

> Commit
> 
>   6d7ccae2e093 ("Revert "HID: allow building hid.ko as an external module"")
> 
> is missing a Signed-off-by from its author and committer.
> 
> Reverts are commits as well and need SOB tags and (preferably) an
> explanatory commit message.

The commit+revert pair is there only for linux-next (to maintain linear 
history there), the branch that contains the actual buggy commit will 
never make it to Linus.

Thanks,

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 9+ messages in thread

* linux-next: Signed-off-by missing for commit in the hid tree
@ 2020-06-24  7:52 Stephen Rothwell
  2020-06-24  7:56 ` Jiri Kosina
  0 siblings, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2020-06-24  7:52 UTC (permalink / raw)
  To: Jiri Kosina, Benjamin Tissoires
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

Hi all,

Commit

  6d7ccae2e093 ("Revert "HID: allow building hid.ko as an external module"")

is missing a Signed-off-by from its author and committer.

Reverts are commits as well and need SOB tags and (preferably) an
explanatory commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the hid tree
  2020-06-20 21:51 Stephen Rothwell
@ 2020-06-22  7:59 ` Cristian Klein
  0 siblings, 0 replies; 9+ messages in thread
From: Cristian Klein @ 2020-06-22  7:59 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Jiri Kosina, Benjamin Tissoires, Linux Next Mailing List,
	Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

On Sun, Jun 21, 2020 at 07:51:24AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   470376737e88 ("HID: allow building hid.ko as an external module")
> 
> is missing a Signed-off-by from its author.
> 
> -- 
> Cheers,
> Stephen Rothwell

Hi,

My bad. Please find attached the corrected patch.

Cheers,
Cristian

[-- Attachment #2: 0001-Allow-building-hid.ko-as-an-external-module.patch --]
[-- Type: text/x-diff, Size: 2478 bytes --]

From 8005724373d8cecb241c013d16b2242c7c1fb39e Mon Sep 17 00:00:00 2001
From: Cristian Klein <cristian.klein@elastisys.com>
Date: Mon, 22 Jun 2020 08:47:58 +0200
Subject: [PATCH] Allow building hid.ko as an "external" module

For quickly testing USB HID quirks with a larger community, it is useful
to be able to build hid.ko as an external module, e.g., against the
source code of the running kernel.

Before this patch this failed as follows:
```
$ make -C /lib/modules/$(uname -r)/build M=$PWD/drivers/hid
make: Entering directory '/usr/src/linux-headers-5.3.0-51-generic'
  CC [M]  /home/cklein/linux/drivers/hid/i2c-hid/i2c-hid-core.o
  CC [M]  /home/cklein/linux/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.o
  LD [M]  /home/cklein/linux/drivers/hid/i2c-hid/i2c-hid.o
  CC [M]  /home/cklein/linux/drivers/hid/intel-ish-hid/ishtp/init.o
  CC [M]  /home/cklein/linux/drivers/hid/intel-ish-hid/ishtp/hbm.o
  CC [M]  /home/cklein/linux/drivers/hid/intel-ish-hid/ishtp/client.o
  CC [M]  /home/cklein/linux/drivers/hid/intel-ish-hid/ishtp/bus.o
  CC [M]  /home/cklein/linux/drivers/hid/intel-ish-hid/ishtp/dma-if.o
  CC [M]  /home/cklein/linux/drivers/hid/intel-ish-hid/ishtp/client-buffers.o
  LD [M]  /home/cklein/linux/drivers/hid/intel-ish-hid/intel-ishtp.o
  CC [M]  /home/cklein/linux/drivers/hid/intel-ish-hid/ipc/ipc.o
/home/cklein/linux/drivers/hid/intel-ish-hid/ipc/ipc.c:12:10: fatal error: client.h: No such file or directory
   12 | #include "client.h"
      |          ^~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.build:290: /home/cklein/linux/drivers/hid/intel-ish-hid/ipc/ipc.o] Error 1
make[1]: *** [scripts/Makefile.build:519: /home/cklein/linux/drivers/hid/intel-ish-hid] Error 2
make: *** [Makefile:1656: _module_/home/cklein/linux/drivers/hid] Error 2
make: Leaving directory '/usr/src/linux-headers-5.3.0-51-generic'
```

Signed-off-by: Cristian Klein <cristian.klein@elastisys.com>
---
 drivers/hid/intel-ish-hid/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/intel-ish-hid/Makefile b/drivers/hid/intel-ish-hid/Makefile
index f0a82b1c7..db4974c43 100644
--- a/drivers/hid/intel-ish-hid/Makefile
+++ b/drivers/hid/intel-ish-hid/Makefile
@@ -23,4 +23,4 @@ intel-ishtp-hid-objs += ishtp-hid-client.o
 obj-$(CONFIG_INTEL_ISH_FIRMWARE_DOWNLOADER) += intel-ishtp-loader.o
 intel-ishtp-loader-objs += ishtp-fw-loader.o
 
-ccflags-y += -I $(srctree)/$(src)/ishtp
+ccflags-y += -I $(src)/ishtp
-- 
2.20.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* linux-next: Signed-off-by missing for commit in the hid tree
@ 2020-06-20 21:51 Stephen Rothwell
  2020-06-22  7:59 ` Cristian Klein
  0 siblings, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2020-06-20 21:51 UTC (permalink / raw)
  To: Jiri Kosina, Benjamin Tissoires
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Cristian Klein

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

Hi all,

Commit

  470376737e88 ("HID: allow building hid.ko as an external module")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2022-07-25 11:43 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-15 21:17 linux-next: Signed-off-by missing for commit in the hid tree Stephen Rothwell
2018-05-16 14:21 ` Rodrigo Rivas Costa
2018-05-17  0:46   ` Stephen Rothwell
2020-06-20 21:51 Stephen Rothwell
2020-06-22  7:59 ` Cristian Klein
2020-06-24  7:52 Stephen Rothwell
2020-06-24  7:56 ` Jiri Kosina
2021-08-21  0:46 Stephen Rothwell
2022-07-25 11:43 Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).