LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: linux-integrity@vger.kernel.org,
	Linux-Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] ima: Fix pr_fmt() redefinition
Date: Thu, 17 May 2018 14:17:59 +0200	[thread overview]
Message-ID: <20180517121759.r6tqw3mj43morfwu@dell5510> (raw)
In-Reply-To: <1526558695.3306.11.camel@linux.vnet.ibm.com>

Hi Mimi,

> On Thu, 2018-05-17 at 12:47 +0200, Petr Vorel wrote:
> > Previous definition was too late and caused problems in powerpc allyesconfig:
> > security/integrity/ima/ima_kexec.c:18:0: warning: "pr_fmt" redefined
> >  #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

> > In file included from include/linux/kernel.h:14:0,
> >                  from include/asm-generic/bug.h:18,
> >                  from arch/powerpc/include/asm/bug.h:128,
> >                  from include/linux/bug.h:5,
> >                  from include/linux/seq_file.h:7,
> >                  from security/integrity/ima/ima_kexec.c:13:
> > include/linux/printk.h:288:0: note: this is the location of the previous definition
> >  #define pr_fmt(fmt) fmt

> > Fixes: 3dea0d93d257 ("ima: Unify logging")

> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>

> As the original patch hasn't been upstreamed yet, I'll squash this fix
> with the original patch.
Make sense, thanks!

> thanks!

> Mimi


Kind regards,
Petr

      reply	other threads:[~2018-05-17 12:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17 10:47 Petr Vorel
2018-05-17 12:04 ` Mimi Zohar
2018-05-17 12:17   ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180517121759.r6tqw3mj43morfwu@dell5510 \
    --to=pvorel@suse.cz \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=zohar@linux.vnet.ibm.com \
    --subject='Re: [PATCH] ima: Fix pr_fmt() redefinition' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).