LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] i2c: synquacer: fix fence-post error in retry loop
@ 2018-05-09 19:47 Peter Rosin
  2018-05-14 10:35 ` Ard Biesheuvel
  2018-05-17 13:41 ` Wolfram Sang
  0 siblings, 2 replies; 3+ messages in thread
From: Peter Rosin @ 2018-05-09 19:47 UTC (permalink / raw)
  To: linux-kernel; +Cc: Peter Rosin, Ard Biesheuvel, linux-i2c

There is a difference between attempts and retries.

Signed-off-by: Peter Rosin <peda@axentia.se>
---
 drivers/i2c/busses/i2c-synquacer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-synquacer.c b/drivers/i2c/busses/i2c-synquacer.c
index a021f866d8c2..915f5edbab33 100644
--- a/drivers/i2c/busses/i2c-synquacer.c
+++ b/drivers/i2c/busses/i2c-synquacer.c
@@ -509,7 +509,7 @@ static int synquacer_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,
 
 	dev_dbg(i2c->dev, "calculated timeout %d ms\n", i2c->timeout_ms);
 
-	for (retry = 0; retry < adap->retries; retry++) {
+	for (retry = 0; retry <= adap->retries; retry++) {
 		ret = synquacer_i2c_doxfer(i2c, msgs, num);
 		if (ret != -EAGAIN)
 			return ret;
-- 
2.11.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] i2c: synquacer: fix fence-post error in retry loop
  2018-05-09 19:47 [PATCH] i2c: synquacer: fix fence-post error in retry loop Peter Rosin
@ 2018-05-14 10:35 ` Ard Biesheuvel
  2018-05-17 13:41 ` Wolfram Sang
  1 sibling, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2018-05-14 10:35 UTC (permalink / raw)
  To: Peter Rosin; +Cc: Linux Kernel Mailing List, linux-i2c

On 9 May 2018 at 21:47, Peter Rosin <peda@axentia.se> wrote:
> There is a difference between attempts and retries.
>
> Signed-off-by: Peter Rosin <peda@axentia.se>

Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  drivers/i2c/busses/i2c-synquacer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-synquacer.c b/drivers/i2c/busses/i2c-synquacer.c
> index a021f866d8c2..915f5edbab33 100644
> --- a/drivers/i2c/busses/i2c-synquacer.c
> +++ b/drivers/i2c/busses/i2c-synquacer.c
> @@ -509,7 +509,7 @@ static int synquacer_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,
>
>         dev_dbg(i2c->dev, "calculated timeout %d ms\n", i2c->timeout_ms);
>
> -       for (retry = 0; retry < adap->retries; retry++) {
> +       for (retry = 0; retry <= adap->retries; retry++) {
>                 ret = synquacer_i2c_doxfer(i2c, msgs, num);
>                 if (ret != -EAGAIN)
>                         return ret;
> --
> 2.11.0
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] i2c: synquacer: fix fence-post error in retry loop
  2018-05-09 19:47 [PATCH] i2c: synquacer: fix fence-post error in retry loop Peter Rosin
  2018-05-14 10:35 ` Ard Biesheuvel
@ 2018-05-17 13:41 ` Wolfram Sang
  1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2018-05-17 13:41 UTC (permalink / raw)
  To: Peter Rosin; +Cc: linux-kernel, Ard Biesheuvel, linux-i2c

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

On Wed, May 09, 2018 at 09:47:26PM +0200, Peter Rosin wrote:
> There is a difference between attempts and retries.
> 
> Signed-off-by: Peter Rosin <peda@axentia.se>

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-17 13:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-09 19:47 [PATCH] i2c: synquacer: fix fence-post error in retry loop Peter Rosin
2018-05-14 10:35 ` Ard Biesheuvel
2018-05-17 13:41 ` Wolfram Sang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).