LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	x86@kernel.org, Ingo Molnar <mingo@redhat.com>,
	"H . Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org,
	Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Laura Abbott <labbott@redhat.com>, Josef Bacik <jbacik@fb.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Subject: Re: [PATCH -tip v3 4/7] kprobes: Ignore break_handler
Date: Fri, 18 May 2018 08:16:36 +0200	[thread overview]
Message-ID: <20180518061635.GA27960@gmail.com> (raw)
In-Reply-To: <152651511510.25583.17622383189254834099.stgit@devbox>


* Masami Hiramatsu <mhiramat@kernel.org> wrote:

> Ignore break_handler related code because it was only
> used by jprobe and jprobe is removed.
> 
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
>  Documentation/kprobes.txt |    2 +-
>  kernel/kprobes.c          |   39 +++++----------------------------------
>  2 files changed, 6 insertions(+), 35 deletions(-)

Even after all these changes there's quite a bit of ->break_handler() use:

triton:~/tip> git grep -w break_handler
arch/arc/kernel/kprobes.c:              if (p->break_handler && p->break_handler(p, regs)) {
arch/arm/probes/kprobes/core.c:                  * for calling the break_handler below on re-entry,
arch/arm/probes/kprobes/core.c:         if (cur->break_handler && cur->break_handler(cur, regs)) {
arch/arm64/kernel/probes/kprobes.c:                      * for calling the break_handler below on re-entry,
arch/arm64/kernel/probes/kprobes.c:             if (cur_kprobe->break_handler  &&
arch/arm64/kernel/probes/kprobes.c:                  cur_kprobe->break_handler(cur_kprobe, regs)) {
arch/ia64/kernel/kprobes.c:                     if (p->break_handler && p->break_handler(p, regs)) {
arch/mips/kernel/kprobes.c:                     if (p->break_handler && p->break_handler(p, regs))
arch/powerpc/kernel/kprobes.c:                  if (p->break_handler && p->break_handler(p, regs)) {
arch/s390/kernel/kprobes.c:                      * for calling the break_handler below on re-entry
arch/s390/kernel/kprobes.c:             if (p->break_handler && p->break_handler(p, regs)) {
arch/s390/kernel/kprobes.c:                      * break_handler "returns" to the original
arch/sh/kernel/kprobes.c:                       if (p->break_handler && p->break_handler(p, regs)) {
arch/sh/kernel/kprobes.c:                                       if (p->break_handler &&
arch/sh/kernel/kprobes.c:                                           p->break_handler(p, args->regs))
arch/sparc/kernel/kprobes.c:                    if (p->break_handler && p->break_handler(p, regs))
arch/x86/include/asm/kprobes.h:  * a post_handler or break_handler).
include/linux/kprobes.h:        kprobe_break_handler_t break_handler;

Nothing appears to be actually _setting_ the break_handler, so all of this is 
stale code as well which should be removed?

Thanks,

	Ingo

  reply	other threads:[~2018-05-18  6:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-16 23:56 [PATCH -tip v3 0/7] kprobes: x86: Cleanup jprobe implementation on x86 Masami Hiramatsu
2018-05-16 23:57 ` [PATCH -tip v3 1/7] Documentation/kprobes: Fix to remove remaining jprobe Masami Hiramatsu
2018-05-16 23:57 ` [PATCH -tip v3 2/7] kprobes: Remove jprobe API implementation Masami Hiramatsu
2018-05-16 23:58 ` [PATCH -tip v3 3/7] x86: kprobes: Remove jprobe implementation Masami Hiramatsu
2018-05-16 23:58 ` [PATCH -tip v3 4/7] kprobes: Ignore break_handler Masami Hiramatsu
2018-05-18  6:16   ` Ingo Molnar [this message]
2018-05-18 13:38     ` Masami Hiramatsu
2018-05-18  6:20   ` Ingo Molnar
2018-05-18 14:14     ` Masami Hiramatsu
2018-05-16 23:59 ` [PATCH -tip v3 5/7] x86: " Masami Hiramatsu
2018-05-18  6:26   ` Ingo Molnar
2018-05-18 13:42     ` Masami Hiramatsu
2018-05-16 23:59 ` [PATCH -tip v3 6/7] bpf: error-inject: x86: Fix unbalanced preempt-count for function override Masami Hiramatsu
2018-05-17  0:00 ` [PATCH -tip v3 7/7] x86: kprobes: Do not disable preempt on int3 path Masami Hiramatsu
2018-05-18  6:23 ` [PATCH -tip v3 0/7] kprobes: x86: Cleanup jprobe implementation on x86 Ingo Molnar
2018-05-18 14:10   ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180518061635.GA27960@gmail.com \
    --to=mingo@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=ananth@linux.vnet.ibm.com \
    --cc=ast@kernel.org \
    --cc=hpa@zytor.com \
    --cc=jbacik@fb.com \
    --cc=labbott@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=ravi.bangoria@linux.vnet.ibm.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --subject='Re: [PATCH -tip v3 4/7] kprobes: Ignore break_handler' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).