LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: rishabhb@codeaurora.org
Cc: Stephen Boyd <swboyd@chromium.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm@lists.infradead.org, tsoni@codeaurora.org,
ckadabi@codeaurora.org, evgreen@chromium.org
Subject: Re: [PATCH v6 1/2] dt-bindings: Documentation for qcom, llcc
Date: Fri, 18 May 2018 09:31:54 -0500 [thread overview]
Message-ID: <20180518143154.GA6224@rob-hp-laptop> (raw)
In-Reply-To: <079348edcb511cefb9f4d76877d50cb7@codeaurora.org>
On Wed, May 16, 2018 at 04:32:27PM -0700, rishabhb@codeaurora.org wrote:
> On 2018-05-16 11:08, Stephen Boyd wrote:
> > Quoting rishabhb@codeaurora.org (2018-05-16 10:33:14)
> > > On 2018-05-16 10:03, Stephen Boyd wrote:
> > > > Quoting Rishabh Bhatnagar (2018-05-08 13:22:00)
> > >
> > > >> +
> > > >> +- max-slices:
> > > >> + usage: required
> > > >> + Value Type: <u32>
> > > >> + Definition: Number of cache slices supported by hardware
> > > >> +
> > > >> +Example:
> > > >> +
> > > >> + llcc: qcom,llcc@1100000 {
> > > >
> > > > cache-controller@1100000 ?
> > > >
> > > We have tried to use consistent naming convention as in llcc_*
> > > everywhere.
> > > Using cache-controller will mix and match the naming convention.
> > > Also in
> > > the documentation it is explained what llcc is and its full form.
> > >
> >
> > DT prefers standard node names as opposed to vendor specific node names.
> > Isn't it a cache controller? I fail to see why this can't be done.
> Hi Stephen,
> The driver is vendor specific and also for uniformity purposes we preferred
> to go with this name.
Almost *every* node and driver is vendor specific. Please do as Stephen
suggested.
Rob
next prev parent reply other threads:[~2018-05-18 14:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 20:21 [PATCH v6 0/2] SDM845 System Cache Driver Rishabh Bhatnagar
2018-05-08 20:22 ` [PATCH v6 1/2] dt-bindings: Documentation for qcom, llcc Rishabh Bhatnagar
2018-05-16 17:03 ` Stephen Boyd
2018-05-16 17:33 ` rishabhb
2018-05-16 18:08 ` Stephen Boyd
2018-05-16 23:32 ` rishabhb
2018-05-18 14:31 ` Rob Herring [this message]
2018-05-08 20:22 ` [PATCH v6 2/2] drivers: soc: Add LLCC driver Rishabh Bhatnagar
2018-05-10 20:15 ` Evan Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518143154.GA6224@rob-hp-laptop \
--to=robh@kernel.org \
--cc=ckadabi@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-arm@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rishabhb@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).