LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: acelan.kao@canonical.com
Cc: jcliburn@gmail.com, chris.snook@gmail.com, rakesh@tuxera.com,
	netdev@vger.kernel.org, emily.chien@canonical.com,
	andrew@lunn.ch, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Revert "alx: remove WoL support"
Date: Sun, 20 May 2018 23:18:20 -0400 (EDT)	[thread overview]
Message-ID: <20180520.231820.868530785962553925.davem@davemloft.net> (raw)
In-Reply-To: <CAFv23Q=RGo5Tw4sL5GiYM69xeGUPReiBE290rnzCvOPezQinCg@mail.gmail.com>

From: AceLan Kao <acelan.kao@canonical.com>
Date: Mon, 21 May 2018 11:14:00 +0800

> We are willing to fix the issue, but we don't have a machine to
> reproduce it, and the WoL feature has been removed 5 years ago, it's
> hard to find those buggy machines.

Have you bothered to ask the person who did the revert?

> WoL is a feature that is only used by a very small group of people,
> and the wake up issue looks like only happens on some
> platforms. Which means only small part of the group of people are
> affected.

One of those people was the wireless networking stack maintainer.

> So, it's not a serious issue worth to remove it from alx driver.

I disagree.

You must fix the regression solved by the revert, before adding
WoL support back to the driver.

I'm not going to say this again.

Thank you.

  reply	other threads:[~2018-05-21  3:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-14  3:28 AceLan Kao
2018-05-14 13:35 ` David Miller
2018-05-21  3:14   ` AceLan Kao
2018-05-21  3:18     ` David Miller [this message]
2018-05-28  5:06       ` AceLan Kao
2018-05-29 14:57         ` David Miller
2018-05-30  2:10 AceLan Kao
2018-05-30 13:58 ` Andrew Lunn
2018-05-31  2:13   ` AceLan Kao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180520.231820.868530785962553925.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=acelan.kao@canonical.com \
    --cc=andrew@lunn.ch \
    --cc=chris.snook@gmail.com \
    --cc=emily.chien@canonical.com \
    --cc=jcliburn@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rakesh@tuxera.com \
    --subject='Re: [PATCH v2] Revert "alx: remove WoL support"' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).