LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Ezequiel Garcia <ezequiel@collabora.com> To: linux-media@vger.kernel.org Cc: kernel@collabora.com, Hans Verkuil <hverkuil@xs4all.nl>, Mauro Carvalho Chehab <mchehab@osg.samsung.com>, Shuah Khan <shuahkh@osg.samsung.com>, Pawel Osciak <pawel@osciak.com>, Alexandre Courbot <acourbot@chromium.org>, Sakari Ailus <sakari.ailus@iki.fi>, Brian Starkey <brian.starkey@arm.com>, linux-kernel@vger.kernel.org, Gustavo Padovan <gustavo.padovan@collabora.com>, Ezequiel Garcia <ezequiel@collabora.com> Subject: [PATCH v10 05/16] vb2: move vb2_ops functions to videobuf2-core.[ch] Date: Mon, 21 May 2018 13:59:35 -0300 [thread overview] Message-ID: <20180521165946.11778-6-ezequiel@collabora.com> (raw) In-Reply-To: <20180521165946.11778-1-ezequiel@collabora.com> From: Gustavo Padovan <gustavo.padovan@collabora.com> vb2_ops_wait_prepare() and vb2_ops_wait_finish() were in the wrong file. Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com> --- drivers/media/common/videobuf2/videobuf2-core.c | 14 ++++++++++++++ drivers/media/common/videobuf2/videobuf2-v4l2.c | 14 -------------- include/media/videobuf2-core.h | 18 ++++++++++++++++++ include/media/videobuf2-v4l2.h | 18 ------------------ 4 files changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c index f1feb45c1e37..61e7b6407586 100644 --- a/drivers/media/common/videobuf2/videobuf2-core.c +++ b/drivers/media/common/videobuf2/videobuf2-core.c @@ -677,6 +677,20 @@ int vb2_verify_memory_type(struct vb2_queue *q, } EXPORT_SYMBOL(vb2_verify_memory_type); +/* vb2_ops helpers. Only use if vq->lock is non-NULL. */ + +void vb2_ops_wait_prepare(struct vb2_queue *vq) +{ + mutex_unlock(vq->lock); +} +EXPORT_SYMBOL_GPL(vb2_ops_wait_prepare); + +void vb2_ops_wait_finish(struct vb2_queue *vq) +{ + mutex_lock(vq->lock); +} +EXPORT_SYMBOL_GPL(vb2_ops_wait_finish); + int vb2_core_reqbufs(struct vb2_queue *q, enum vb2_memory memory, unsigned int *count) { diff --git a/drivers/media/common/videobuf2/videobuf2-v4l2.c b/drivers/media/common/videobuf2/videobuf2-v4l2.c index 886a2d8d5c6c..64503615d00b 100644 --- a/drivers/media/common/videobuf2/videobuf2-v4l2.c +++ b/drivers/media/common/videobuf2/videobuf2-v4l2.c @@ -947,20 +947,6 @@ unsigned long vb2_fop_get_unmapped_area(struct file *file, unsigned long addr, EXPORT_SYMBOL_GPL(vb2_fop_get_unmapped_area); #endif -/* vb2_ops helpers. Only use if vq->lock is non-NULL. */ - -void vb2_ops_wait_prepare(struct vb2_queue *vq) -{ - mutex_unlock(vq->lock); -} -EXPORT_SYMBOL_GPL(vb2_ops_wait_prepare); - -void vb2_ops_wait_finish(struct vb2_queue *vq) -{ - mutex_lock(vq->lock); -} -EXPORT_SYMBOL_GPL(vb2_ops_wait_finish); - MODULE_DESCRIPTION("Driver helper framework for Video for Linux 2"); MODULE_AUTHOR("Pawel Osciak <pawel@osciak.com>, Marek Szyprowski"); MODULE_LICENSE("GPL"); diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h index baa4632c7e59..137f72702101 100644 --- a/include/media/videobuf2-core.h +++ b/include/media/videobuf2-core.h @@ -403,6 +403,24 @@ struct vb2_ops { void (*buf_queue)(struct vb2_buffer *vb); }; +/** + * vb2_ops_wait_prepare - helper function to lock a struct &vb2_queue + * + * @vq: pointer to &struct vb2_queue + * + * ..note:: only use if vq->lock is non-NULL. + */ +void vb2_ops_wait_prepare(struct vb2_queue *vq); + +/** + * vb2_ops_wait_finish - helper function to unlock a struct &vb2_queue + * + * @vq: pointer to &struct vb2_queue + * + * ..note:: only use if vq->lock is non-NULL. + */ +void vb2_ops_wait_finish(struct vb2_queue *vq); + /** * struct vb2_buf_ops - driver-specific callbacks. * diff --git a/include/media/videobuf2-v4l2.h b/include/media/videobuf2-v4l2.h index 3d5e2d739f05..cf83b01dc44e 100644 --- a/include/media/videobuf2-v4l2.h +++ b/include/media/videobuf2-v4l2.h @@ -273,22 +273,4 @@ unsigned long vb2_fop_get_unmapped_area(struct file *file, unsigned long addr, unsigned long len, unsigned long pgoff, unsigned long flags); #endif -/** - * vb2_ops_wait_prepare - helper function to lock a struct &vb2_queue - * - * @vq: pointer to &struct vb2_queue - * - * ..note:: only use if vq->lock is non-NULL. - */ -void vb2_ops_wait_prepare(struct vb2_queue *vq); - -/** - * vb2_ops_wait_finish - helper function to unlock a struct &vb2_queue - * - * @vq: pointer to &struct vb2_queue - * - * ..note:: only use if vq->lock is non-NULL. - */ -void vb2_ops_wait_finish(struct vb2_queue *vq); - #endif /* _MEDIA_VIDEOBUF2_V4L2_H */ -- 2.16.3
next prev parent reply other threads:[~2018-05-21 17:01 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-21 16:59 [PATCH v10 00/16] V4L2 Explicit Synchronization Ezequiel Garcia 2018-05-21 16:59 ` [PATCH v10 01/16] videobuf2: Make struct vb2_buffer refcounted Ezequiel Garcia 2018-05-25 6:41 ` sathyam panda 2018-05-29 13:17 ` Ezequiel Garcia 2018-05-29 15:11 ` sathyam panda 2018-05-21 16:59 ` [PATCH v10 02/16] xilinx: regroup caps on querycap Ezequiel Garcia 2018-05-21 16:59 ` [PATCH v10 03/16] hackrf: group device capabilities Ezequiel Garcia 2018-05-21 16:59 ` [PATCH v10 04/16] omap3isp: " Ezequiel Garcia 2018-05-21 16:59 ` Ezequiel Garcia [this message] 2018-05-21 16:59 ` [PATCH v10 06/16] vb2: add is_unordered callback for drivers Ezequiel Garcia 2018-05-21 16:59 ` [PATCH v10 07/16] v4l: add unordered flag to format description ioctl Ezequiel Garcia 2018-05-21 16:59 ` [PATCH v10 08/16] v4l: mark unordered formats Ezequiel Garcia 2018-05-22 11:55 ` Hans Verkuil 2018-05-23 10:30 ` Ezequiel Garcia 2018-05-23 11:29 ` Hans Verkuil 2018-05-21 16:59 ` [PATCH v10 09/16] cobalt: add .is_unordered() for cobalt Ezequiel Garcia 2018-05-22 11:57 ` Hans Verkuil 2018-05-21 16:59 ` [PATCH v10 10/16] vb2: mark codec drivers as unordered Ezequiel Garcia 2018-05-21 16:59 ` [PATCH v10 11/16] vb2: add explicit fence user API Ezequiel Garcia 2018-05-22 12:05 ` Hans Verkuil 2018-05-22 15:51 ` Ezequiel Garcia 2018-05-21 16:59 ` [PATCH v10 12/16] vb2: add in-fence support to QBUF Ezequiel Garcia 2018-05-22 12:37 ` Hans Verkuil 2018-05-22 16:22 ` Ezequiel Garcia 2018-05-22 16:48 ` Hans Verkuil 2018-05-22 17:41 ` Ezequiel Garcia 2018-05-25 6:12 ` sathyam panda 2018-05-21 16:59 ` [PATCH v10 13/16] vb2: add out-fence " Ezequiel Garcia 2018-05-22 12:41 ` Hans Verkuil 2018-05-25 16:36 ` Brian Starkey 2018-05-21 16:59 ` [PATCH v10 14/16] v4l: introduce the fences capability Ezequiel Garcia 2018-05-21 16:59 ` [PATCH v10 15/16] v4l: Add V4L2_CAP_FENCES to drivers Ezequiel Garcia 2018-05-21 16:59 ` [PATCH v10 16/16] v4l: Document explicit synchronization behavior Ezequiel Garcia
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180521165946.11778-6-ezequiel@collabora.com \ --to=ezequiel@collabora.com \ --cc=acourbot@chromium.org \ --cc=brian.starkey@arm.com \ --cc=gustavo.padovan@collabora.com \ --cc=hverkuil@xs4all.nl \ --cc=kernel@collabora.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mchehab@osg.samsung.com \ --cc=pawel@osciak.com \ --cc=sakari.ailus@iki.fi \ --cc=shuahkh@osg.samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).