LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
	Alexander Usyskin <alexander.usyskin@intel.com>,
	linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm: separate cmd_ready/go_idle from runtime_pm
Date: Tue, 22 May 2018 12:17:32 +0300	[thread overview]
Message-ID: <20180522091732.GA5228@linux.intel.com> (raw)
In-Reply-To: <20180516194600.28189-1-tomas.winkler@intel.com>

On Wed, May 16, 2018 at 10:46:00PM +0300, Tomas Winkler wrote:
> New wrappers are added tpm_cmd_ready() and tpm_go_idle() wrappers to
> streamline tpm_try_transmit code. TPM_TRANSMIT_UNLOCKED flag is abused to
> resolve tpm spaces recursive calls to tpm_transmit().

This looks good and all but I don't think we want to abuse anything in
the driver code, do we?

In other words, either

1. New flag is to be added.
2. Rename the existing flag to something else than UNLOCKED (perhaps
   SPACE).

 /Jarkko

  reply	other threads:[~2018-05-22  9:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-16 19:46 Tomas Winkler
2018-05-22  9:17 ` Jarkko Sakkinen [this message]
2018-05-22  9:27   ` Winkler, Tomas
2018-05-23 13:16     ` Jarkko Sakkinen
2018-05-23 13:48       ` Winkler, Tomas
2018-05-30 10:50         ` Jarkko Sakkinen
2018-05-30 10:52           ` Winkler, Tomas
2018-05-30 23:37             ` Jarkko Sakkinen
2018-06-06 11:01               ` Winkler, Tomas
2018-06-07 10:24                 ` Jarkko Sakkinen
2018-06-07 11:03                   ` Winkler, Tomas
2018-06-07 14:26                     ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180522091732.GA5228@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=alexander.usyskin@intel.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=tomas.winkler@intel.com \
    --subject='Re: [PATCH] tpm: separate cmd_ready/go_idle from runtime_pm' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).