LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "Michal Vokáč" <vokac.m@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, f.fainelli@gmail.com,
	vivien.didelot@savoirfairelinux.com, andrew@lunn.ch,
	mark.rutland@arm.com, davem@davemloft.net,
	michal.vokac@ysoft.com
Subject: Re: [PATCH net-next v2 1/7] net: dsa: qca8k: Add QCA8334 binding documentation
Date: Tue, 22 May 2018 14:40:39 -0500	[thread overview]
Message-ID: <20180522194039.GA15413@rob-hp-laptop> (raw)
In-Reply-To: <1526987792-56861-2-git-send-email-michal.vokac@ysoft.com>

On Tue, May 22, 2018 at 01:16:26PM +0200, Michal Vokáč wrote:
> Add support for the four-port variant of the Qualcomm QCA833x switch.
> 
> The CPU port default link settings can be reconfigured using
> a fixed-link sub-node.
> 
> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
> ---
> Changes in v2:
>  - Add commit message and document fixed-link binding.
> 
>  .../devicetree/bindings/net/dsa/qca8k.txt          | 23 +++++++++++++++++++++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt
> index 9c67ee4..15b9057 100644
> --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt
> @@ -2,7 +2,10 @@
>  
>  Required properties:
>  
> -- compatible: should be "qca,qca8337"
> +- compatible: should be one of:
> +    "qca,qca8334"
> +    "qca,qca8337"
> +
>  - #size-cells: must be 0
>  - #address-cells: must be 1
>  
> @@ -14,6 +17,20 @@ port and PHY id, each subnode describing a port needs to have a valid phandle
>  referencing the internal PHY connected to it. The CPU port of this switch is
>  always port 0.
>  
> +A CPU port node has the following optional property:

s/property/node/

Otherwise,

Reviewed-by: Rob Herring <robh@kernel.org>

  reply	other threads:[~2018-05-22 19:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-22 11:16 [PATCH net-next v2 0/7] Add support for QCA8334 switch Michal Vokáč
2018-05-22 11:16 ` [PATCH net-next v2 1/7] net: dsa: qca8k: Add QCA8334 binding documentation Michal Vokáč
2018-05-22 19:40   ` Rob Herring [this message]
2018-05-22 20:50     ` Michal
2018-05-22 21:58   ` Andrew Lunn
2018-05-22 11:16 ` [PATCH net-next v2 2/7] net: dsa: qca8k: Add support for QCA8334 switch Michal Vokáč
2018-05-22 21:58   ` [PATCH net-next v2 2/7] net: dsa: qca8k: Add support for QCA8334 switch' Andrew Lunn
2018-05-22 11:16 ` [PATCH net-next v2 3/7] net: dsa: qca8k: Enable RXMAC when bringing up a port Michal Vokáč
2018-05-22 11:16 ` [PATCH net-next v2 4/7] net: dsa: qca8k: Force CPU port to its highest bandwidth Michal Vokáč
2018-05-22 11:16 ` [PATCH net-next v2 5/7] net: dsa: qca8k: Allow overwriting CPU port setting Michal Vokáč
2018-05-22 11:16 ` [PATCH net-next v2 6/7] net: dsa: qca8k: Replace GPL boilerplate by SPDX Michal Vokáč
2018-05-22 11:16 ` [PATCH net-next v2 7/7] net: dsa: qca8k: Remove redundant parentheses Michal Vokáč

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180522194039.GA15413@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=michal.vokac@ysoft.com \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    --cc=vokac.m@gmail.com \
    --subject='Re: [PATCH net-next v2 1/7] net: dsa: qca8k: Add QCA8334 binding documentation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).